Squashed commit of the following:

commit 5b3d68a
Author: Lenin Mehedy <[email protected]>
Date:   Wed Feb 12 23:37:56 2025 +1100

    feat: handle multiple contexts during network deploy (#1369)

    Signed-off-by: Lenin Mehedy <[email protected]>

commit ea24bc4
Author: Jeromy Cannon <[email protected]>
Date:   Wed Feb 12 00:19:23 2025 +0000

    more todos

    Signed-off-by: Jeromy Cannon <[email protected]>

commit 71388dd
Author: Jeromy Cannon <[email protected]>
Date:   Wed Feb 12 00:10:26 2025 +0000

    pushing latest

    Signed-off-by: Jeromy Cannon <[email protected]>

commit 209c2cd
Author: Jeromy Cannon <[email protected]>
Date:   Tue Feb 11 21:53:15 2025 +0000

    updated cluster ref flag description

    Signed-off-by: Jeromy Cannon <[email protected]>

commit 1a0a337
Author: Jeromy Cannon <[email protected]>
Date:   Tue Feb 11 21:52:12 2025 +0000

    renamed flag clusterName to clusterRef

    Signed-off-by: Jeromy Cannon <[email protected]>

commit f4087bf
Author: Jeromy Cannon <[email protected]>
Date:   Tue Feb 11 21:41:02 2025 +0000

    saving progress

    Signed-off-by: Jeromy Cannon <[email protected]>

commit 537fc1a
Author: Jeromy Cannon <[email protected]>
Date:   Tue Feb 11 20:51:03 2025 +0000

    set the networks deploy config with the contexts and the consensus nodes for later use

    Signed-off-by: Jeromy Cannon <[email protected]>

commit e86e94c
Author: Jeromy Cannon <[email protected]>
Date:   Tue Feb 11 20:07:53 2025 +0000

    added base test for getContexts

    Signed-off-by: Jeromy Cannon <[email protected]>

Signed-off-by: Jeromy Cannon <[email protected]>

Author: jeromy-cannon

src/commands/base.ts

@@ -3,6 +3,7 @@
  */
 
 import paths from 'path';
+import path from 'path';
 import {MissingArgumentError, SoloError} from '../core/errors.js';
 import {ShellRunner} from '../core/shell_runner.js';
 import {type LeaseManager} from '../core/lease/lease_manager.js';
@@ -17,11 +18,12 @@ import {type Opts} from '../types/command_types.js';
 import {type CommandFlag} from '../types/flag_types.js';
 import {type Lease} from '../core/lease/lease.js';
 import {Listr} from 'listr2';
-import path from 'path';
 import * as constants from '../core/constants.js';
 import fs from 'fs';
 import {Task} from '../core/task.js';
 import {ConsensusNode} from '../core/model/consensus_node.js';
+import {type ClusterRef, type ClusterRefs} from '../core/config/remote/types.js';
+import {Flags} from './flags.js';
 
 export interface CommandHandlers {
   parent: BaseCommand;
@@ -72,6 +74,7 @@ export abstract class BaseCommand extends ShellRunner {
     return `${chartRepo}/${chartReleaseName}`;
   }
 
+  // FIXME @Deprecated. Use prepareValuesFilesMap instead to support multi-cluster
   public prepareValuesFiles(valuesFile: string) {
     let valuesArg = '';
     if (valuesFile) {
@@ -85,6 +88,80 @@ export abstract class BaseCommand extends ShellRunner {
     return valuesArg;
   }
 
+  /**
+   * Prepare the values files map for each cluster
+   *
+   * <p> Order of precedence:
+   * <ol>
+   *   <li> Chart's default values file (if chartDirectory is set) </li>
+   *   <li> Profile values file </li>
+   *   <li> User's values file </li>
+   * </ol>
+   * @param contextRefs - the map of cluster references
+   * @param valuesFileInput - the values file input string
+   * @param chartDirectory - the chart directory
+   * @param profileValuesFile - the profile values file
+   */
+  static prepareValuesFilesMap(
+    contextRefs: ClusterRefs,
+    chartDirectory?: string,
+    profileValuesFile?: string,
+    valuesFileInput?: string,
+  ): Record<ClusterRef, string> {
+    // initialize the map with an empty array for each cluster-ref
+    const valuesFiles: Record<ClusterRef, string> = {};
+    Object.entries(contextRefs).forEach(([clusterRef]) => {
+      valuesFiles[clusterRef] = '';
+    });
+
+    // add the chart's default values file for each cluster-ref if chartDirectory is set
+    // this should be the first in the list of values files as it will be overridden by user's input
+    if (chartDirectory) {
+      const chartValuesFile = path.join(chartDirectory, 'solo-deployment', 'values.yaml');
+      for (const clusterRef in valuesFiles) {
+        valuesFiles[clusterRef] += ` --values ${chartValuesFile}`;
+      }
+    }
+
+    if (profileValuesFile) {
+      const parsed = Flags.parseValuesFilesInput(profileValuesFile);
+      Object.entries(parsed).forEach(([clusterRef, files]) => {
+        let vf = '';
+        files.forEach(file => {
+          vf += ` --values ${file}`;
+        });
+
+        if (clusterRef === Flags.KEY_COMMON) {
+          Object.entries(valuesFiles).forEach(([cf]) => {
+            valuesFiles[cf] += vf;
+          });
+        } else {
+          valuesFiles[clusterRef] += vf;
+        }
+      });
+    }
+
+    if (valuesFileInput) {
+      const parsed = Flags.parseValuesFilesInput(valuesFileInput);
+      Object.entries(parsed).forEach(([clusterRef, files]) => {
+        let vf = '';
+        files.forEach(file => {
+          vf += ` --values ${file}`;
+        });
+
+        if (clusterRef === Flags.KEY_COMMON) {
+          Object.entries(valuesFiles).forEach(([clusterRef]) => {
+            valuesFiles[clusterRef] += vf;
+          });
+        } else {
+          valuesFiles[clusterRef] += vf;
+        }
+      });
+    }
+
+    return valuesFiles;
+  }
+
   public getConfigManager(): ConfigManager {
     return this.configManager;
   }
@@ -104,6 +181,7 @@ export abstract class BaseCommand extends ShellRunner {
     // build the dynamic class that will keep track of which properties are used
     const NewConfigClass = class {
       private usedConfigs: Map<string, number>;
+
       constructor() {
         // the map to keep track of which properties are used
         this.usedConfigs = new Map();
@@ -255,18 +333,20 @@ export abstract class BaseCommand extends ShellRunner {
     const consensusNodes: ConsensusNode[] = [];
 
     // using the remoteConfigManager to get the consensus nodes
-    Object.values(this.getRemoteConfigManager().components.consensusNodes).forEach(node => {
-      consensusNodes.push(
-        new ConsensusNode(
-          node.name,
-          node.nodeId,
-          node.namespace,
-          node.cluster,
-          // use local config to get the context
-          this.getLocalConfig().clusterRefs[node.cluster],
-        ),
-      );
-    });
+    if (this.getRemoteConfigManager()?.components?.consensusNodes) {
+      Object.values(this.getRemoteConfigManager().components.consensusNodes).forEach(node => {
+        consensusNodes.push(
+          new ConsensusNode(
+            node.name,
+            node.nodeId,
+            node.namespace,
+            node.cluster,
+            // use local config to get the context
+            this.getLocalConfig().clusterRefs[node.cluster],
+          ),
+        );
+      });
+    }
 
     // return the consensus nodes
     return consensusNodes;

src/commands/cluster/configs.ts

@@ -72,7 +72,7 @@ export const resetConfigBuilder = async function (argv, ctx, task) {
   this.parent.getConfigManager().update(argv);
 
   ctx.config = {
-    clusterName: this.parent.getConfigManager().getFlag(flags.clusterName) as string,
+    clusterName: this.parent.getConfigManager().getFlag(flags.clusterRef) as string,
     clusterSetupNamespace: this.parent.getConfigManager().getFlag(flags.clusterSetupNamespace) as string,
   } as ClusterResetConfigClass;
 

src/commands/cluster/flags.ts

@@ -15,7 +15,7 @@ export const SETUP_FLAGS = {
   requiredFlagsWithDisabledPrompt: [],
   optionalFlags: [
     flags.chartDirectory,
-    flags.clusterName,
+    flags.clusterRef,
     flags.clusterSetupNamespace,
     flags.deployCertManager,
     flags.deployCertManagerCrds,
@@ -29,7 +29,7 @@ export const SETUP_FLAGS = {
 export const RESET_FLAGS = {
   requiredFlags: [],
   requiredFlagsWithDisabledPrompt: [],
-  optionalFlags: [flags.clusterName, flags.clusterSetupNamespace, flags.force, flags.quiet],
+  optionalFlags: [flags.clusterRef, flags.clusterSetupNamespace, flags.force, flags.quiet],
 };
 
 export const CONNECT_FLAGS = {
@@ -39,7 +39,7 @@ export const CONNECT_FLAGS = {
     flags.devMode,
     flags.deployment,
     flags.quiet,
-    flags.clusterName,
+    flags.clusterRef,
     flags.context,
     flags.namespace,
     flags.userEmailAddress,

src/commands/cluster/tasks.ts

@@ -266,7 +266,7 @@ export class ClusterCommandTasks {
         const configManager = this.parent.getConfigManager();
         const isQuiet = configManager.getFlag<boolean>(flags.quiet);
         const deploymentName: string = configManager.getFlag<DeploymentName>(flags.deployment);
-        let clusters = splitFlagInput(configManager.getFlag<string>(flags.clusterName));
+        let clusters = splitFlagInput(configManager.getFlag<string>(flags.clusterRef));
         const contexts = splitFlagInput(configManager.getFlag<string>(flags.context));
         const namespace = configManager.getFlag<NamespaceName>(flags.namespace);
         const localConfig = this.parent.getLocalConfig();
@@ -319,7 +319,7 @@ export class ClusterCommandTasks {
 
             // Prompt user for clusters and contexts
             else {
-              const promptedClusters = await flags.clusterName.prompt(task, '');
+              const promptedClusters = await flags.clusterRef.prompt(task, '');
               clusters = splitFlagInput(promptedClusters);
 
               for (const cluster of clusters) {

src/commands/deployment.ts

@@ -16,7 +16,7 @@ import {type SoloListrTask} from '../types/index.js';
 import {type Opts} from '../types/command_types.js';
 import {ErrorMessages} from '../core/error_messages.js';
 import {splitFlagInput} from '../core/helpers.js';
-import {type NamespaceName} from '../core/kube/resources/namespace/namespace_name.js';
+import {NamespaceName} from '../core/kube/resources/namespace/namespace_name.js';
 import {type ClusterChecks} from '../core/cluster_checks.js';
 import {container} from 'tsyringe-neo';
 import {InjectTokens} from '../core/dependency_injection/inject_tokens.js';
@@ -35,18 +35,19 @@ export class DeploymentCommand extends BaseCommand {
       flags.quiet,
       flags.context,
       flags.namespace,
-      flags.clusterName,
+      flags.clusterRef,
       flags.userEmailAddress,
       flags.deployment,
       flags.deploymentClusters,
+      flags.nodeAliasesUnparsed,
     ];
   }
 
   private static get LIST_DEPLOYMENTS_FLAGS_LIST(): CommandFlag[] {
-    return [flags.quiet, flags.clusterName];
+    return [flags.quiet, flags.clusterRef];
   }
 
-  private async create(argv: any): Promise<boolean> {
+  public async create(argv: any): Promise<boolean> {
     const self = this;
 
     interface Config {
@@ -57,6 +58,7 @@ export class DeploymentCommand extends BaseCommand {
       namespace: NamespaceName;
       deployment: DeploymentName;
       deploymentClusters: string[];
+      nodeAliases: string[];
     }
 
     interface Context {
@@ -82,6 +84,7 @@ export class DeploymentCommand extends BaseCommand {
               namespace: self.configManager.getFlag<NamespaceName>(flags.namespace),
               deployment: self.configManager.getFlag<DeploymentName>(flags.deployment),
               deploymentClusters: splitFlagInput(self.configManager.getFlag<string>(flags.deploymentClusters)),
+              nodeAliases: splitFlagInput(self.configManager.getFlag<string>(flags.nodeAliasesUnparsed)),
             } as Config;
 
             self.logger.debug('Prepared config', {config: ctx.config, cachedConfig: self.configManager.config});
@@ -93,7 +96,13 @@ export class DeploymentCommand extends BaseCommand {
           title: 'Add new deployment to local config',
           task: async (ctx, task) => {
             const {deployments} = this.localConfig;
-            const {deployment, namespace, deploymentClusters} = ctx.config;
+            const {deployment, namespace: configNamespace, deploymentClusters} = ctx.config;
+            let namespace = configNamespace;
+            if (!namespace?.name) {
+              namespace = NamespaceName.of(deployment);
+              ctx.config.namespace = namespace;
+              this.configManager.setFlag(flags.namespace, namespace);
+            }
             deployments[deployment] = {
               namespace: namespace.name,
               clusters: deploymentClusters,
@@ -183,10 +192,10 @@ export class DeploymentCommand extends BaseCommand {
             self.configManager.update(argv);
             self.logger.debug('Updated config with argv', {config: self.configManager.config});
 
-            await self.configManager.executePrompt(task, [flags.clusterName]);
+            await self.configManager.executePrompt(task, [flags.clusterRef]);
 
             ctx.config = {
-              clusterName: self.configManager.getFlag<ClusterRef>(flags.clusterName),
+              clusterName: self.configManager.getFlag<ClusterRef>(flags.clusterRef),
             } as Config;
 
             self.logger.debug('Prepared config', {config: ctx.config, cachedConfig: self.configManager.config});