Skip to content

Commit ea24bc4

Browse files
committed
more todos
Signed-off-by: Jeromy Cannon <[email protected]>
1 parent 71388dd commit ea24bc4

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed

src/commands/network.ts

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -602,10 +602,12 @@ export class NetworkCommand extends BaseCommand {
602602
title: `Install chart '${constants.SOLO_DEPLOYMENT_CHART}'`,
603603
task: async ctx => {
604604
const config = ctx.config;
605+
// TODO: @Lenin, run for each cluster
605606
if (await self.chartManager.isChartInstalled(config.namespace, constants.SOLO_DEPLOYMENT_CHART)) {
606607
await self.chartManager.uninstall(config.namespace, constants.SOLO_DEPLOYMENT_CHART);
607608
}
608609

610+
// TODO: @Lenin, run for each cluster
609611
await this.chartManager.install(
610612
config.namespace,
611613
constants.SOLO_DEPLOYMENT_CHART,
@@ -622,9 +624,11 @@ export class NetworkCommand extends BaseCommand {
622624
const config = ctx.config;
623625

624626
// nodes
627+
// TODO: @Lenin, needs to use config.consensusNodes
625628
for (const nodeAlias of config.nodeAliases) {
626629
subTasks.push({
627630
title: `Check Node: ${chalk.yellow(nodeAlias)}`,
631+
// TODO: @Lenin, needs to use config.consensusNodes for both node name and context
628632
task: async () =>
629633
await self.k8Factory
630634
.default()
@@ -654,9 +658,11 @@ export class NetworkCommand extends BaseCommand {
654658
const config = ctx.config;
655659

656660
// HAProxy
661+
// TODO: @Lenin, needs to use config.consensusNodes
657662
for (const nodeAlias of config.nodeAliases) {
658663
subTasks.push({
659664
title: `Check HAProxy for: ${chalk.yellow(nodeAlias)}`,
665+
// TODO: @Lenin, needs to use config.consensusNodes for both node name and context
660666
task: async () =>
661667
await self.k8Factory
662668
.default()
@@ -671,9 +677,11 @@ export class NetworkCommand extends BaseCommand {
671677
}
672678

673679
// Envoy Proxy
680+
// TODO: @Lenin, needs to use config.consensusNodes
674681
for (const nodeAlias of config.nodeAliases) {
675682
subTasks.push({
676683
title: `Check Envoy Proxy for: ${chalk.yellow(nodeAlias)}`,
684+
// TODO: @Lenin, needs to use config.consensusNodes for both node name and context
677685
task: async () =>
678686
await self.k8Factory
679687
.default()
@@ -704,6 +712,7 @@ export class NetworkCommand extends BaseCommand {
704712
// minio
705713
subTasks.push({
706714
title: 'Check MinIO',
715+
// TODO: @Lenin, needs to run for each cluster
707716
task: async ctx =>
708717
await self.k8Factory
709718
.default()
@@ -1001,6 +1010,7 @@ export class NetworkCommand extends BaseCommand {
10011010
} = ctx;
10021011
const cluster = this.remoteConfigManager.currentCluster;
10031012

1013+
// TODO: @Lenin, we can update this to use config.consensusNodes and provide the correct cluster per node
10041014
await this.remoteConfigManager.modify(async remoteConfig => {
10051015
for (const nodeAlias of nodeAliases) {
10061016
remoteConfig.components.add(

src/core/platform_installer.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -168,6 +168,7 @@ export class PlatformInstaller {
168168
data[fileName] = Base64.encode(fileContents);
169169
}
170170

171+
// TODO: @Lenin, will need to run for each cluster
171172
const secretCreated = await this.k8Factory
172173
.default()
173174
.secrets()
@@ -213,7 +214,7 @@ export class PlatformInstaller {
213214
data[fileName] = Base64.encode(fileContents);
214215
}
215216
}
216-
217+
// TODO: @Lenin, will need to run for each cluster
217218
const secretCreated = await this.k8Factory
218219
.default()
219220
.secrets()

0 commit comments

Comments
 (0)