fixed some unit test cases

Signed-off-by: Jeromy Cannon <[email protected]>

Author: jeromy-cannon

test/unit/commands/network.test.ts

@@ -155,8 +155,8 @@ describe('NetworkCommand unit tests', () => {
 
     it('Install function is called with expected parameters', async () => {
       const networkCommand = new NetworkCommand(opts);
-      sinon.stub(networkCommand, 'getConsensusNodes').resolves([]);
-      sinon.stub(networkCommand, 'getContexts').resolves([]);
+      sinon.stub(networkCommand, 'getConsensusNodes').returns([]);
+      sinon.stub(networkCommand, 'getContexts').returns([]);
       await networkCommand.deploy(argv);
 
       expect(opts.chartManager.install.args[0][0].name).to.equal(constants.SOLO_TEST_CLUSTER);
@@ -168,19 +168,23 @@ describe('NetworkCommand unit tests', () => {
     });
 
     it('Should use local chart directory', async () => {
-      argv[flags.chartDirectory.name] = 'test-directory';
-      argv[flags.force.name] = true;
-
-      const networkCommand = new NetworkCommand(opts);
-      sinon.stub(networkCommand, 'getConsensusNodes').resolves([]);
-      sinon.stub(networkCommand, 'getContexts').resolves([]);
-      await networkCommand.deploy(argv);
-      expect(opts.chartManager.install.args[0][0].name).to.equal(constants.SOLO_TEST_CLUSTER);
-      expect(opts.chartManager.install.args[0][1]).to.equal(constants.SOLO_DEPLOYMENT_CHART);
-      expect(opts.chartManager.install.args[0][2]).to.equal(
-        path.join(ROOT_DIR, 'test-directory', constants.SOLO_DEPLOYMENT_CHART),
-      );
-      expect(opts.chartManager.install.args[0][3]).to.equal(version.SOLO_CHART_VERSION);
+      try {
+        argv[flags.chartDirectory.name] = 'test-directory';
+        argv[flags.force.name] = true;
+
+        sinon.stub(NetworkCommand.prototype, 'getConsensusNodes').returns([]);
+        sinon.stub(NetworkCommand.prototype, 'getContexts').returns([]);
+        const networkCommand = new NetworkCommand(opts);
+        await networkCommand.deploy(argv);
+        expect(opts.chartManager.install.args[0][0].name).to.equal(constants.SOLO_TEST_CLUSTER);
+        expect(opts.chartManager.install.args[0][1]).to.equal(constants.SOLO_DEPLOYMENT_CHART);
+        expect(opts.chartManager.install.args[0][2]).to.equal(
+          path.join(ROOT_DIR, 'test-directory', constants.SOLO_DEPLOYMENT_CHART),
+        );
+        expect(opts.chartManager.install.args[0][3]).to.equal(version.SOLO_CHART_VERSION);
+      } finally {
+        sinon.restore();
+      }
     });
 
     it('Should use prepare config correctly for all clusters', async () => {

test/unit/core/certificate_manager.test.ts

@@ -23,9 +23,9 @@ describe('Certificate Manager', () => {
   let certificateManager: CertificateManager;
 
   before(() => {
+    resetForTest();
     sinon.stub(K8Client.prototype, 'init').returns(k8InitSpy);
     sinon.stub(K8ClientSecrets.prototype, 'create').resolves(true);
-    resetForTest();
     argv[flags.namespace.name] = 'namespace';
     const configManager: ConfigManager = container.resolve(InjectTokens.ConfigManager);
     configManager.update(argv);