-
Notifications
You must be signed in to change notification settings - Fork 69
feat: Add persistent shard and realm support to Client #1395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Ivan Ivanov <[email protected]>
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
Codecov ReportAttention: Patch coverage is
... and 10 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Signed-off-by: Ivan Ivanov <[email protected]>
Signed-off-by: Ivan Ivanov <[email protected]>
Signed-off-by: Ivan Ivanov <[email protected]>
Signed-off-by: Ivan Ivanov <[email protected]>
Signed-off-by: Ivan Ivanov <[email protected]>
Signed-off-by: Ivan Ivanov <[email protected]>
Signed-off-by: Ivan Ivanov <[email protected]>
Signed-off-by: Ivan Ivanov <[email protected]>
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) |
Signed-off-by: Ivan Ivanov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description:
Adds persistent realm and shard according to hiero-ledger/sdk-collaboration-hub#28
New APIs
ClientForNetworkV2
: extracts the shard and realm from the network map and persists itGetShard
GetRealm
Updated APIs
ClientFromConfig
: can now accept shard and realm into the json schemaDeprecation notice
ClientForMirrorNetworkWithRealmAndShard
: UseClientForMirrorNetworkWithShardAndRealm
instead.ClientForNetwork
: UseClientForNetworkV2
instead.Related issue(s):
Fixes #1404
Notes for reviewer:
Checklist