Update rest tests for non-zero shard/realm #11513
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jesse Nelson <[email protected]>
Signed-off-by: Jesse Nelson <[email protected]>
Signed-off-by: Jesse Nelson <[email protected]>
Signed-off-by: Jesse Nelson <[email protected]>
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| result.push(entry); | ||
| } | ||
|
|
||
| return result.join('&').replace('&', '?'); |
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding High test
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 1 day ago
To fix the issue, we need to ensure that all occurrences of '&' in the string are replaced. This can be achieved by using a regular expression with the global (g) flag instead of a string literal as the first argument to replace. Specifically, the string '&' should be replaced with a regular expression /&/g. This change ensures that every occurrence of '&' in the string is replaced.
Suggested changeset
1
rest/__tests__/integrationUtils.js
| @@ -76,3 +76,3 @@ | ||
|
|
||
| return result.join('&').replace('&', '?'); | ||
| return result.join('&').replace(/&/g, '?'); | ||
| } else { |
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue(s):
Fixes #10744
Notes for reviewer:
Checklist