Skip to content

Upgrade to express 5.1.0 #11511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Upgrade to express 5.1.0 #11511

wants to merge 2 commits into from

Conversation

xin-hedera
Copy link
Contributor

Description:

Related issue(s):

Fixes #10864

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Xin Li <[email protected]>
@xin-hedera xin-hedera linked an issue Jul 3, 2025 that may be closed by this pull request
2 tasks
@xin-hedera xin-hedera self-assigned this Jul 3, 2025
@xin-hedera xin-hedera added enhancement Type: New feature rest Area: REST API labels Jul 3, 2025
@xin-hedera xin-hedera added this to the 0.134.0 milestone Jul 3, 2025
@lfdt-bot
Copy link

lfdt-bot commented Jul 3, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

router.getExt('/:contractId/state', ContractController.getContractStateById);
router.getExt('/:contractId/results/logs', ContractController.getContractLogsById);
// must add after '/:contractId/results/logs' for proper conflict resolution
router.getExt('/:contractId/results/:consensusTimestamp', ContractController.getContractResultsByTimestamp);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

express 5.x doesn't support regex in path variable. this also trap us into path conflict between /:contractId/results/logs and /:contractId/results/:consensusTimestamp

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for b06f49b1 94.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (b06f49b) Report Missing Report Missing Report Missing
Head commit (98e701c) 59397 36192 60.93%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#11511) 100 94 94.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type: New feature rest Area: REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Express 5.x
2 participants