-
Notifications
You must be signed in to change notification settings - Fork 122
Add k6 test for fungible token lifecycle #11507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Nikolay Nikolov <[email protected]>
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesFootnotes
|
Signed-off-by: Nikolay Nikolov <[email protected]>
tools/k6/src/web3/test/complex-functions/contractCallComplexFunctionsTokenLifecycle.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Nikolay Nikolov <[email protected]>
Signed-off-by: Nikolay Nikolov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to also check the solidity file in somewhere and link to it in the k6 README.
Signed-off-by: Nikolay Nikolov <[email protected]>
69b5592
Signed-off-by: Nikolay Nikolov <[email protected]>
Signed-off-by: Nikolay Nikolov <[email protected]>
From my previous comment:
We should have a section in the README that describes and links to the source of various k6 tests so that we can reproduce k6 data easily. It doesn't have to be for every existing test but at least the one you added in this PR. |
This PR adds a k6 test that covers the lifecycle of a fungible token. The contract function that
The detailed contract function is:
Related issue(s):
Fixes #10624
Notes for reviewer:
Changes in the deploy branch for mainnet config will be done in a separate PR.
There are following complex scenarios that will be added and the contract will be updated in stages. Therefore to avoid new contract deploy on mainnet on each PR those tests will be disabled from the flag
RUN_COMPLEX_TESTS
until the contract is fully ready and deployed once at the end.Checklist