-
Notifications
You must be signed in to change notification settings - Fork 122
Add debug tracers needed for modularized workflow #11477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ith modularized code Signed-off-by: Ivan Kavaldzhiev <[email protected]>
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) |
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
…ty class Signed-off-by: Ivan Kavaldzhiev <[email protected]>
…-modularized-workflow
…-modularized-workflow
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
…-modularized-workflow
…-modularized-workflow
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
…-modularized-workflow
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesFootnotes
|
web3/src/main/java/org/hiero/mirror/web3/service/TransactionExecutionService.java
Outdated
Show resolved
Hide resolved
web3/src/main/java/org/hiero/mirror/web3/evm/contracts/execution/traceability/TracerUtils.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ivan Kavaldzhiev <[email protected]>
@@ -62,6 +64,8 @@ public class TransactionExecutionService { | |||
private final MirrorNodeEvmProperties mirrorNodeEvmProperties; | |||
private final OpcodeTracer opcodeTracer; | |||
private final MirrorOperationTracer mirrorOperationTracer; | |||
private final OpcodeActionTracer opcodeActionTracer; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
opcodeTracer
and mirrorOperationTracer
above are not used anymore and can be removed from this file.
Description:
This PR adds missing Tracers needed, so that the web3 module works properly for eth_debugTraceTransaction with modularized workflow.
Key changes:
Related issue(s):
Fixes #11424
Notes for reviewer:
Checklist