Skip to content

fix: charts install workflow after introducing Read-Only mode #3932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

acuarica
Copy link
Contributor

@acuarica acuarica commented Jul 14, 2025

Description:

This PR fixes the chart test workflow by setting the READ_ONLY flag. In Read-Only mode, both OPERATOR_ID_MAIN and OPERATOR_KEY_MAIN values are not checked at the start of the Relay/WebSocket.

Related issue(s):

Fixes #3931.

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Luis Mastrangelo <[email protected]>
@acuarica acuarica added this to the 0.70.0 milestone Jul 14, 2025
@acuarica acuarica self-assigned this Jul 14, 2025
@acuarica acuarica added the bug Something isn't working label Jul 14, 2025
@acuarica acuarica linked an issue Jul 14, 2025 that may be closed by this pull request
Copy link

github-actions bot commented Jul 14, 2025

Test Results

 20 files  ±0  277 suites  ±0   18m 1s ⏱️ -1s
702 tests ±0  697 ✅ ±0  5 💤 ±0  0 ❌ ±0 
718 runs  ±0  713 ✅ ±0  5 💤 ±0  0 ❌ ±0 

Results for commit 295f7f5. ± Comparison against base commit 34ce7f7.

♻️ This comment has been updated with latest results.

Signed-off-by: Luis Mastrangelo <[email protected]>
@acuarica acuarica changed the title fix: Charts install workflow after introducing Read-Only mode fix: charts install workflow after introducing Read-Only mode Jul 14, 2025
@acuarica acuarica marked this pull request as ready for review July 14, 2025 15:11
@acuarica acuarica requested review from a team as code owners July 14, 2025 15:11
@acuarica acuarica requested a review from quiet-node July 14, 2025 15:11
Copy link
Contributor

@quiet-node quiet-node left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@natanasow natanasow merged commit f82f220 into main Jul 15, 2025
69 of 70 checks passed
@natanasow natanasow deleted the 3931-fix-charts-install-ci-workflow-after-read-only-feature branch July 15, 2025 10:02
Copy link

codecov bot commented Jul 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

@@            Coverage Diff             @@
##             main    #3932      +/-   ##
==========================================
+ Coverage   86.60%   86.71%   +0.11%     
==========================================
  Files          87       87              
  Lines        5090     5090              
  Branches     1040     1040              
==========================================
+ Hits         4408     4414       +6     
+ Misses        413      406       -7     
- Partials      269      270       +1     
Flag Coverage Δ
config-service 95.78% <ø> (ø)
relay 81.19% <ø> (ø)
server 80.81% <ø> (ø)
ws-server 61.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Charts / install CI workflow after Read-Only feature
3 participants