-
Notifications
You must be signed in to change notification settings - Fork 83
chore: improves test coverage in ws-server package #3928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+683
−211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Konstantina Blazhukova <[email protected]>
259a958
to
84b4c62
Compare
Signed-off-by: Konstantina Blazhukova <[email protected]>
4d39211
to
bec1eda
Compare
Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
quiet-node
previously approved these changes
Jul 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice set of tests! Great work as always!
acuarica
previously approved these changes
Jul 15, 2025
Signed-off-by: Konstantina Blazhukova <[email protected]>
acuarica
approved these changes
Jul 16, 2025
simzzz
approved these changes
Jul 16, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #3928 +/- ##
==========================================
+ Coverage 86.82% 88.18% +1.36%
==========================================
Files 87 87
Lines 5086 5037 -49
Branches 1038 1020 -18
==========================================
+ Hits 4416 4442 +26
+ Misses 395 330 -65
+ Partials 275 265 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 12 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The goal of this PR is to improve the test coverage of the ws-server package, more precisely of the three following files:
Related issue(s):
Fixes #3908 #3926 #3927
Notes for reviewer:
https://github.com/hiero-ledger/hiero-json-rpc-relay/pull/3928/files#diff-42934bb457ef270c151411688f1ae741d52945651e9c7b74bfe881e815da0c78R30
This change was done, so we can easily test the shouldRateLimitOnMethod method. If the IPRateLimitService is created in the connectionLimiter class itself, its pretty hard to mock it and test the method properly
Checklist