-
Notifications
You must be signed in to change notification settings - Fork 81
feat: implement Jumbo Transaction support and enhance pre-requisite validation for eth_sendRawTransaction #3722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test Results 21 files + 1 266 suites - 18 39m 41s ⏱️ +18s For more details on these failures, see this check. Results for commit 16de375. ± Comparison against base commit 64a04c2. This pull request removes 2 and adds 8 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls review the comments and adress them to be able to be in sync with the funtional needs
790a3db
to
e683d8f
Compare
100b63d
to
1a6bc54
Compare
daf1742
to
7e2de4c
Compare
7e2de4c
to
402d938
Compare
7aff97d
to
6dce594
Compare
02003be
to
734bbaf
Compare
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
d6abc77
to
8d55464
Compare
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]> Revert "fix: removed unused code" This reverts commit dc7afb0. Reapply "fix: removed unused code" This reverts commit 22e72e9806c6fd60218000a0f970fa8ea2886523.
This reverts commit 0443062. Signed-off-by: Logan Nguyen <[email protected]>
This reverts commit 2dc2ff5. Signed-off-by: Logan Nguyen <[email protected]>
9de3b8a
to
4c0e41d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM at first sight.
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tyvm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review and approve .github/workflows/acceptance.yml
Description
This PR introduces a feature flag to allow the Relay to handle jumbo transactions, making it possible to process large transaction payloads directly rather than splitting them across the Hedera File System. Additionally, the PR includes several code improvements for better clarity and added validation.
Key Changes
JUMBO_TX_ENABLED
feature flag (currently set to false as default value) that allows transactions to bypass size limit checkscallDataSize
precheck to validate callData field against 128KB limit.contractCodeSize
precheck to validate smart contract deployments against EIP-170 limit (24KB)parseRawTxAndPrecheck
→validateRawTransaction
parseTxIfNeeded
→parseRawTransaction
sendRawTransactionExtension.spec.ts
, to isolate eth_sendRawTransaction-feature-related tests and reduce the load on the rpc_batch1 suite.Fixes #3573
Fixes #3460