fix: added safe guard for rewardPercentiles size limit #3605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ferparishuertas
previously approved these changes
Mar 28, 2025
quiet-node
force-pushed
the
3527-optimize-memory-usage-for-feehistory-reward-field
branch
from
3d3e252 to
716ad4c
Compare
Signed-off-by: Logan Nguyen <[email protected]>
quiet-node
force-pushed
the
3527-optimize-memory-usage-for-feehistory-reward-field
branch
from
716ad4c to
a105acb
Compare
natanasow
approved these changes
Mar 28, 2025
acuarica
approved these changes
Mar 29, 2025
quiet-node
deleted the
3527-optimize-memory-usage-for-feehistory-reward-field
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds a guard to the feeHistory method to limit the size of the rewardPercentiles array. The maximum allowed size is set to 100 in a new constant, FEE_HISTORY_REWARD_PERCENTILES_MAX_SIZE, preventing excessive memory usage when the rewardPercentiles parameter contains a large number of entries.
Related issue(s):
Fixes #3527
Notes for reviewer:
Checklist