-
Notifications
You must be signed in to change notification settings - Fork 81
feat: add GET /config
route
#3559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Test Results 18 files - 3 236 suites - 66 33m 15s ⏱️ - 15m 32s Results for commit 4413339. ± Comparison against base commit aac3b28. This pull request removes 1 test.
♻️ This comment has been updated with latest results. |
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
/config
endpointhedera_config
RPC method
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3559 +/- ##
==========================================
+ Coverage 85.73% 85.78% +0.05%
==========================================
Files 75 77 +2
Lines 4836 4882 +46
Branches 998 1000 +2
==========================================
+ Hits 4146 4188 +42
- Misses 402 405 +3
- Partials 288 289 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
# Conflicts: # packages/relay/src/index.ts # packages/relay/src/lib/relay.ts
Signed-off-by: nikolay <[email protected]>
hedera_config
RPC method/config
RPC method
Signed-off-by: nikolay <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work but left some Qs
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfecto! LGTM Great work as always!
@natanasow we should update the PR title though it's misleading. |
Fixed 🫡. |
Description:
To provide more transparency and operational insight to developers using the JSON RPC relay, it would be beneficial to expose configuration and deployment block information. Such information could aid in troubleshooting and understanding the context in which the relay is running. However, it's crucial to maintain conformity with the Ethereum JSON RPC API specification, so altering existing endpoints is not desirable.
Solution:
Introduce a new RPC method
/config
. This method could provide the necessary configuration data.Related issue(s):
Fixes #1298
Notes for reviewer:
Checklist