-
Notifications
You must be signed in to change notification settings - Fork 81
chore: turned USE_ASYNC_TX_PROCESSING to true by default #3500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Logan Nguyen <[email protected]>
|
Test Results 19 files - 6 257 suites - 104 38m 43s ⏱️ - 47m 13s For more details on these failures, see this check. Results for commit 868d61f. ± Comparison against base commit 8c0898f. This pull request removes 8 tests.
♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3500 +/- ##
==========================================
+ Coverage 84.36% 85.53% +1.16%
==========================================
Files 69 69
Lines 4734 4734
Branches 999 999
==========================================
+ Hits 3994 4049 +55
+ Misses 434 398 -36
+ Partials 306 287 -19
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Description:
After a team discussion, it was agreed to set USE_ASYNC_TX_PROCESSING to true by default. This enables eth_sendRawTransaction to use fast return, meaning it will return the transaction hash immediately after passing all prechecks, while the processing orchestration runs in the background.
Related issue(s):
Fixes #3317
Notes for reviewer:
Checklist