Skip to content

chore: turned USE_ASYNC_TX_PROCESSING to true by default #3500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

quiet-node
Copy link
Contributor

Description:
After a team discussion, it was agreed to set USE_ASYNC_TX_PROCESSING to true by default. This enables eth_sendRawTransaction to use fast return, meaning it will return the transaction hash immediately after passing all prechecks, while the processing orchestration runs in the background.

Related issue(s):

Fixes #3317

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@quiet-node quiet-node added the internal For changes that affect the project's internal workings but not its outward-facing functionality. label Feb 19, 2025
@quiet-node quiet-node added this to the 0.67.0 milestone Feb 19, 2025
@quiet-node quiet-node self-assigned this Feb 19, 2025
@quiet-node quiet-node requested review from a team as code owners February 19, 2025 20:37
Copy link

github-actions bot commented Feb 19, 2025

Test Results

 19 files   -   6  257 suites   - 104   38m 43s ⏱️ - 47m 13s
617 tests  -   8  612 ✅ +  8  4 💤 ±0  1 ❌  - 16 
671 runs   - 141  666 ✅  - 122  4 💤 ±0  1 ❌  - 19 

For more details on these failures, see this check.

Results for commit 868d61f. ± Comparison against base commit 8c0898f.

This pull request removes 8 tests.
"before all" hook for "emits an approval event" ‑ RPC Server Acceptance Tests Acceptance tests @erc20 Acceptance Tests HTS token should behave like erc20 transfer from when the token owner is not the zero address when the recipient is not the zero address when the spender has enough allowance "before all" hook for "emits an approval event"
"before all" hook for "reverts" ‑ RPC Server Acceptance Tests Acceptance tests @erc20 Acceptance Tests HTS token should behave like erc20 transfer from when the token owner is not the zero address when the recipient is not the zero address when the spender does not have enough allowance when the token owner has enough balance "before all" hook for "reverts"
"before all" hook for "should execute "eth_getCode" for hts token" ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-2 RPC Server Acceptance Tests eth_getCode "before all" hook for "should execute "eth_getCode" for hts token"
"before all" hook in "@api-batch-2 RPC Server Acceptance Tests" ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-2 RPC Server Acceptance Tests "before all" hook in "@api-batch-2 RPC Server Acceptance Tests"
"before all" hook in "HBAR Rate Limit Tests" ‑ RPC Server Acceptance Tests Acceptance tests @hbarlimiter HBAR Limiter Acceptance Tests HBAR Rate Limit Tests "before all" hook in "HBAR Rate Limit Tests"
"before each" hook for "Should allow different accounts associated in the same HbarSpendingPlan to contribute to the same budget" ‑ RPC Server Acceptance Tests Acceptance tests @hbarlimiter HBAR Limiter Acceptance Tests HBAR Rate Limit Tests HBAR Rate Limit For Different Spending Plan Tiers @hbarlimiter-batch2 Preconfigured Tiers PRIVILEGED Tier "before each" hook for "Should allow different accounts associated in the same HbarSpendingPlan to contribute to the same budget"
"before each" hook for "reverts" ‑ RPC Server Acceptance Tests Acceptance tests @erc20 Acceptance Tests HTS token should behave like erc20 transfer from when the token owner is not the zero address when the recipient is not the zero address when the spender does not have enough allowance "before each" hook for "reverts"
"before each" hook for "should execute "eth_getStorageAt" request to get current state changes with passing specific block hash" ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-2 RPC Server Acceptance Tests "before each" hook for "should execute "eth_getStorageAt" request to get current state changes with passing specific block hash"

♻️ This comment has been updated with latest results.

@quiet-node quiet-node merged commit e7d3b27 into main Feb 21, 2025
46 of 50 checks passed
@quiet-node quiet-node deleted the 3317-eth_sendrawtransaction-fast-return-deprecate-the-original-logic-that-waits-for-transactions-to-be-fully-processed-before-returning-the-transaction-hash branch February 21, 2025 16:42
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.53%. Comparing base (8c0898f) to head (868d61f).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3500      +/-   ##
==========================================
+ Coverage   84.36%   85.53%   +1.16%     
==========================================
  Files          69       69              
  Lines        4734     4734              
  Branches      999      999              
==========================================
+ Hits         3994     4049      +55     
+ Misses        434      398      -36     
+ Partials      306      287      -19     
Flag Coverage Δ
config-service 95.16% <ø> (ø)
relay 79.54% <ø> (ø)
server 83.60% <ø> (ø)
ws-server 36.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ckages/config-service/src/services/globalConfig.ts 100.00% <ø> (ø)

... and 4 files with indirect coverage changes

@acuarica acuarica added enhancement New feature or request and removed internal For changes that affect the project's internal workings but not its outward-facing functionality. labels Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
4 participants