-
Notifications
You must be signed in to change notification settings - Fork 81
feat: filter out some methods from batch requests #3497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: nikolay <[email protected]>
Test Results 18 files - 7 236 suites - 125 33m 14s ⏱️ - 52m 42s Results for commit 4e6d9ec. ± Comparison against base commit 8c0898f. This pull request removes 8 and adds 1 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
Signed-off-by: nikolay <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Signed-off-by: nikolay <[email protected]>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! LGTM! Thanks for the great work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3497 +/- ##
==========================================
+ Coverage 84.36% 85.50% +1.13%
==========================================
Files 69 69
Lines 4734 4738 +4
Branches 999 1000 +1
==========================================
+ Hits 3994 4051 +57
+ Misses 434 400 -34
+ Partials 306 287 -19
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Description:
Some methods should not be allowed to be requested as part of a batch.
Debug and Filter APIs to start with, but we might want to leave them in a configurable property that we can extend if needed.
Solution:
New error
code: -32007
message: Method
<method>
is not permitted as part of batch requestsNew Configurable property with the list of the methods that are not allowed for batch.
Add a validation on each request, right before calling
getRequestResult
Related issue(s):
Fixes #1885
Notes for reviewer:
Checklist