-
Notifications
You must be signed in to change notification settings - Fork 81
fix: fixes flaky CI tests in RPC Batch 2 #3495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Simeon Nakov <[email protected]>
Test Results 23 files + 4 303 suites +49 48m 4s ⏱️ + 11m 35s For more details on these failures, see this check. Results for commit edba11b. ± Comparison against base commit ef2d8bb. This pull request removes 2 and adds 12 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Signed-off-by: Simeon Nakov <[email protected]>
Signed-off-by: Simeon Nakov <[email protected]>
Signed-off-by: Simeon Nakov <[email protected]>
Signed-off-by: Simeon Nakov <[email protected]>
Signed-off-by: Simeon Nakov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice attempt! Would it be possible to also take this opportunity to fix the should execute "eth_sendRawTransaction" if the receiver's account has receiver_sig_required disabled'
test? I’ve noticed it fails quite often. If you think it’s better addressed in a separate PR, that works too.
@quiet-node Yes, I did debug that one as well but I still haven't determined an exact cause. I will get back to it in a separate PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few comments
Signed-off-by: Simeon Nakov <[email protected]>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks for looking into this definitely causes time and effort to re-run the CI
@simzzz woops Batch2 still fails pretty consistently |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3495 +/- ##
==========================================
+ Coverage 85.17% 85.64% +0.47%
==========================================
Files 69 75 +6
Lines 4734 4834 +100
Branches 999 998 -1
==========================================
+ Hits 4032 4140 +108
+ Misses 409 405 -4
+ Partials 293 289 -4
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Description:
The beforeAll() block in the eth_getCode suite is timing out.
By optimizing the hook in the RPC API batch 2 and removing unnecessary and expensive calls, and then rerunning the job multiple times - now it fails much less often.
Related issue(s):
Fixes partially #3353
Notes for reviewer:
Checklist