Open
Description
The _CONFIG
object that holds the environment variables configuration requires each entry to have an envName
property. This property is actually equal to its outer key, for example
BATCH_REQUESTS_ENABLED: {
envName: 'BATCH_REQUESTS_ENABLED',
type: 'boolean',
required: false,
defaultValue: true,
},
This is redundant, and may confuse newcomers wanting to contribute to the Relay.
Moreover, it seems this property is not used anywhere besides the loggerService
. However, this can be easily replaced by either using the key directly (and making it type safe), or by including an optional field that declares if the entry should be masked or not.
Once envName
had been replaced in loggerService
, we should remove it from _CONFIG
object.
Additionally, in the same loggerService
, the KNOWN_SECRET_PREFIXES
field is not used and it should be removed as well.