Skip to content

chore: remove Unused class #19237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 19, 2025
Merged

chore: remove Unused class #19237

merged 2 commits into from
May 19, 2025

Conversation

mustafauzunn
Copy link
Contributor

Description:

Remove Unused class

Related issue(s):

Fixes #18461

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Mustafa Uzun <[email protected]>
@mustafauzunn mustafauzunn added this to the v0.63 milestone May 16, 2025
@mustafauzunn mustafauzunn self-assigned this May 16, 2025
Copy link

codecov bot commented May 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #19237      +/-   ##
============================================
- Coverage     69.38%   69.35%   -0.04%     
+ Complexity    23271    23268       -3     
============================================
  Files          2645     2645              
  Lines        100710   100710              
  Branches      10409    10409              
============================================
- Hits          69880    69846      -34     
- Misses        26868    26902      +34     
  Partials       3962     3962              

see 16 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

codacy-production bot commented May 16, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.03% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (a24192e) 100660 73812 73.33%
Head commit (df2d2a6) 100660 (+0) 73778 (-34) 73.29% (-0.03%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#19237) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@mustafauzunn mustafauzunn marked this pull request as ready for review May 16, 2025 10:55
@mustafauzunn mustafauzunn requested review from a team as code owners May 16, 2025 10:55
@mustafauzunn mustafauzunn requested review from imalygin and netopyr May 16, 2025 14:41
@netopyr
Copy link
Contributor

netopyr commented May 16, 2025

@mustafauzunn Did you run a clean build with clean caches when checking the dependencies? The dependency detection mechanism is very fragile.

@mustafauzunn
Copy link
Contributor Author

@mustafauzunn Did you run a clean build with clean caches when checking the dependencies? The dependency detection mechanism is very fragile.

Thanks for the advice. I ran the checks without cache and the checks are passing

@mustafauzunn mustafauzunn merged commit 9f14b14 into main May 19, 2025
48 checks passed
@mustafauzunn mustafauzunn deleted the 18461-remove-unused-class branch May 19, 2025 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Unused class
3 participants