Skip to content

build: Upload hapi test client logs with network logs in CI #19222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2025

Conversation

mhess-swl
Copy link
Contributor

Description:

Current CI failures result in persistence of the network logs, but do not include the logged output of the test client itself. This PR adds that file for each of the hapi test tasks. We also add the *.log filepath to the hapi test tasks that didn't have it.

@mhess-swl mhess-swl self-assigned this May 15, 2025
@mhess-swl mhess-swl requested a review from a team as a code owner May 15, 2025 18:29
@mhess-swl mhess-swl requested a review from jeromy-cannon May 15, 2025 18:29
@mhess-swl mhess-swl modified the milestone: v0.63 May 15, 2025
@mhess-swl mhess-swl assigned mhess-swl and unassigned mhess-swl May 15, 2025
Copy link

codecov bot commented May 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #19222   +/-   ##
=======================================
  Coverage        ?   69.34%           
  Complexity      ?    23260           
=======================================
  Files           ?     2645           
  Lines           ?   100665           
  Branches        ?    10399           
=======================================
  Hits            ?    69811           
  Misses          ?    26891           
  Partials        ?     3963           

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

codacy-production bot commented May 15, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for e90a1c21
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (e90a1c2) Report Missing Report Missing Report Missing
Head commit (35f052f) 100615 73744 73.29%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#19222) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@mhess-swl mhess-swl merged commit d41653d into main May 15, 2025
56 of 61 checks passed
@mhess-swl mhess-swl deleted the test-client-log-ci-uploads branch May 15, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants