Skip to content

chore: Remove AtomicBatch from prod throttles #19216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2025

Conversation

tinker-michaelj
Copy link
Contributor

Copy link

codecov bot commented May 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Impacted file tree graph

@@               Coverage Diff               @@
##             release/0.62   #19216   +/-   ##
===============================================
  Coverage           69.45%   69.45%           
  Complexity          23166    23166           
===============================================
  Files                2629     2629           
  Lines              100195   100195           
  Branches            10346    10346           
===============================================
  Hits                69595    69595           
  Misses              26636    26636           
  Partials             3964     3964           

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

codacy-production bot commented May 15, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (45b3430) 100145 73528 73.42%
Head commit (467eeed) 100145 (+0) 73528 (+0) 73.42% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#19216) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Copy link
Contributor

@poulok poulok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am no longer a codeowner of these files.

@netopyr
Copy link
Contributor

netopyr commented May 15, 2025

I am no longer a codeowner of these files.

Same here

Copy link
Contributor

@Neeharika-Sompalli Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @tinker-michaelj

Copy link
Contributor

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@Neeharika-Sompalli Neeharika-Sompalli merged commit 853e54f into release/0.62 May 16, 2025
43 of 44 checks passed
@Neeharika-Sompalli Neeharika-Sompalli deleted the r62-disable-atomic-batch-throttles branch May 16, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants