Skip to content

fix: Fix the transactionFee in the record for ConsensusSubmitMessage with custom fees #19201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2025

Conversation

Neeharika-Sompalli
Copy link
Contributor

Cherry-pick #19195

Fixes #19197

Removes extra charging of the synthetic CryptoTransfer to assess custom fee when a ConsensusSubmitMessage for a topic with custom fees is submitted.
Also, fixes the transactionFee in the record to be same as the credits to fee collection accounts.

Signed-off-by: Neeharika-Sompalli <[email protected]>
@Neeharika-Sompalli Neeharika-Sompalli requested review from a team as code owners May 14, 2025 19:51
@Neeharika-Sompalli Neeharika-Sompalli added this to the v0.63 milestone May 14, 2025
@Neeharika-Sompalli Neeharika-Sompalli self-assigned this May 14, 2025
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 82ea7e21
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (82ea7e2) Report Missing Report Missing Report Missing
Head commit (d08ed14) 100647 73770 73.30%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#19201) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Copy link

codecov bot commented May 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #19201   +/-   ##
=======================================
  Coverage        ?   69.34%           
  Complexity      ?    23254           
=======================================
  Files           ?     2645           
  Lines           ?   100697           
  Branches        ?    10403           
=======================================
  Hits            ?    69826           
  Misses          ?    26897           
  Partials        ?     3974           
Files with missing lines Coverage Δ Complexity Δ
...hedera/node/app/spi/workflows/DispatchOptions.java 100.00% <ø> (ø) 14.00 <0.00> (?)

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Neeharika-Sompalli Neeharika-Sompalli merged commit 1228c40 into main May 16, 2025
56 of 62 checks passed
@Neeharika-Sompalli Neeharika-Sompalli deleted the 19197-D-transaction-fee branch May 16, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix transactionFee on the TransactionRecord for ConsensusSubmitMessage with custom fees
4 participants