Skip to content

fix: Use CompositeFilter for console logging #19171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 13, 2025
Merged

fix: Use CompositeFilter for console logging #19171

merged 2 commits into from
May 13, 2025

Conversation

timo0
Copy link
Member

@timo0 timo0 commented May 13, 2025

The SATE_HASH marker was still in the console output

@timo0 timo0 added this to the v0.61 milestone May 13, 2025
@timo0 timo0 self-assigned this May 13, 2025
@timo0 timo0 requested a review from a team as a code owner May 13, 2025 09:49
netopyr
netopyr previously approved these changes May 13, 2025
View reviewed changes
Copy link
Contributor

@netopyr netopyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should show log statements without a marker in the console. Otherwise LGTM - thanks @timo0

@timo0
review
835f327 
Signed-off-by: Timo Brandstätter <[email protected]>
netopyr
netopyr approved these changes May 13, 2025
View reviewed changes
Copy link
Contributor

@netopyr netopyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @timo0

@timo0 timo0 merged commit fb1e41a into main May 13, 2025
43 checks passed
@timo0 timo0 deleted the fix-console-logger branch May 13, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@netopyr netopyr netopyr approved these changes

Assignees

@timo0 timo0

Labels
None yet
Projects
None yet
Milestone
v0.61
Development

Successfully merging this pull request may close these issues.
2 participants
@timo0 @netopyr