fix: Remove default shard and realm constants #19123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Hess <[email protected]>
Signed-off-by: Matt Hess <[email protected]>
Signed-off-by: Matt Hess <[email protected]>
Signed-off-by: Matt Hess <[email protected]>
Signed-off-by: Matt Hess <[email protected]>
Signed-off-by: Matt Hess <[email protected]>
Signed-off-by: Matt Hess <[email protected]>
Signed-off-by: Zhivko Kelchev <[email protected]>
Signed-off-by: Zhivko Kelchev <[email protected]>
Signed-off-by: ibankov <[email protected]>
Signed-off-by: ibankov <[email protected]>
Signed-off-by: ibankov <[email protected]>
Signed-off-by: ibankov <[email protected]>
Signed-off-by: ibankov <[email protected]>
Signed-off-by: ibankov <[email protected]>
Signed-off-by: Zhivko Kelchev <[email protected]>
…ouple-hapiTestSmartContracts
Signed-off-by: Zhivko Kelchev <[email protected]>
Signed-off-by: ibankov <[email protected]>
…docouple-hapiTestToken # Conflicts: # hedera-node/test-clients/src/main/java/com/hedera/services/bdd/spec/transactions/HapiTxnOp.java
Signed-off-by: Zhivko Kelchev <[email protected]>
…ouple-hapiTestSmartContracts
Signed-off-by: Zhivko Kelchev <[email protected]>
Signed-off-by: ibankov <[email protected]>
Signed-off-by: Zhivko Kelchev <[email protected]>
…docouple-hapiTestToken
Signed-off-by: Zhivko Kelchev <[email protected]>
Signed-off-by: Zhivko Kelchev <[email protected]>
Signed-off-by: Zhivko Kelchev <[email protected]>
Signed-off-by: Zhivko Kelchev <[email protected]>
… 18957-shard-realm-decouple-hapiTestMisc
… 18957-shard-realm-decouple-hapiTestMisc
Signed-off-by: Zhivko Kelchev <[email protected]>
Signed-off-by: Zhivko Kelchev <[email protected]>
…o default-shard-realm-decouple
JivkoKelchev
changed the base branch from
main
to
18957-shard-realm-decouple-hapiTestMisc
Signed-off-by: Zhivko Kelchev <[email protected]>
mhess-swl
reviewed
May 13, 2025
hedera-node/test-clients/src/main/java/com/hedera/services/bdd/spec/queries/HapiQueryOp.java
Outdated
Show resolved
Hide resolved
...nts/src/main/java/com/hedera/services/bdd/spec/transactions/contract/HapiContractCreate.java
Outdated
Show resolved
Hide resolved
hedera-node/test-clients/src/main/java/com/hedera/services/bdd/spec/HapiPropertySource.java
Show resolved
Hide resolved
hedera-node/test-clients/src/main/java/com/hedera/services/bdd/spec/HapiPropertySource.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Zhivko Kelchev <[email protected]>
mhess-swl
reviewed
May 14, 2025
...nts/src/main/java/com/hedera/services/bdd/spec/transactions/contract/HapiContractCreate.java
Show resolved
Hide resolved
mhess-swl
previously approved these changes
May 14, 2025
Signed-off-by: Zhivko Kelchev <[email protected]>
mhess-swl
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Encapsulate static initialization of shard and realm properties.
static String asEntityString(final long num)Related issue(s):
Partially fixes #18962
Notes for reviewer:
Checklist