fix: Move jumbo transaction size check only at ingest #19118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ibankov <[email protected]>
mhess-swl
reviewed
May 13, 2025
hedera-node/hedera-app/src/main/java/com/hedera/node/app/workflows/ingest/IngestChecker.java
Show resolved
Hide resolved
hedera-node/hedera-app/src/main/java/com/hedera/node/app/workflows/ingest/IngestChecker.java
Show resolved
Hide resolved
vtronkov
approved these changes
May 15, 2025
Neeharika-Sompalli
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Since we call
transactionChecker.parseAndCheck()in PreHandle withmaxTxnSize = HederaConfig.nodeTransactionMaxBytes, there’s a discrepancy in themaxTxnSizevalue whencheckJumboTransactionBody()is called in preHandle(). Therefore, we should move this check exclusively to the ingest phase.Related issue(s):
Fixes #
Notes for reviewer:
Checklist