Skip to content

chore: cherry pick #13479 - redirectForAccount proxy contract support #13668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jun 5, 2024

Conversation

lukelee-sl
Copy link
Contributor

@lukelee-sl lukelee-sl commented Jun 4, 2024

Description:

Cherry pick #13479. This cherry-pick does contain the same number of files in the original pr (#13479). The reason is that this pr was based off of pr #13326 which was separately checked in. The commit history for this pr starts with commit a8a4855 and all subsequent commits (minus the Merge branch develop commits) were included in this cherry pick.

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

lukelee-sl added 14 commits June 4, 2024 08:08
Signed-off-by: lukelee-sl <[email protected]>
Signed-off-by: lukelee-sl <[email protected]>
Signed-off-by: lukelee-sl <[email protected]>
…arify where the function selector bytes comes from

Signed-off-by: lukelee-sl <[email protected]>
@lukelee-sl lukelee-sl added this to the v0.51 milestone Jun 4, 2024
@lukelee-sl lukelee-sl self-assigned this Jun 4, 2024
@lukelee-sl lukelee-sl requested review from a team as code owners June 4, 2024 18:26
@lukelee-sl lukelee-sl requested a review from a team June 4, 2024 18:26
@lukelee-sl lukelee-sl requested review from timo0 and artemananiev June 4, 2024 18:26
@lukelee-sl lukelee-sl changed the title Chore: cherry pick #13479 - redirectForAccount proxy contract support chore: cherry pick #13479 - redirectForAccount proxy contract support Jun 4, 2024
Copy link

github-actions bot commented Jun 4, 2024

Node: Unit Test Results

  2 319 files  + 1    2 319 suites  +1   3h 29m 41s ⏱️ + 2m 58s
112 676 tests +12  112 607 ✅ +12  69 💤 ±0  0 ❌ ±0 
121 187 runs  +12  121 118 ✅ +12  69 💤 ±0  0 ❌ ±0 

Results for commit 8645fb4. ± Comparison against base commit b8a8897.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 83.52941% with 14 lines in your changes missing coverage. Please review.

Project coverage is 67.57%. Comparing base (b8a8897) to head (d0db5bb).

Current head d0db5bb differs from pull request most recent head 8645fb4

Please upload reports for the commit 8645fb4 to get more accurate results.

Files Patch % Lines
...service/contract/impl/exec/utils/FrameBuilder.java 63.15% 3 Missing and 4 partials ⚠️
...e/contract/impl/state/AbstractProxyEvmAccount.java 88.88% 3 Missing ⚠️
...ec/processors/CustomContractCreationProcessor.java 33.33% 1 Missing and 1 partial ⚠️
...pl/exec/processors/CustomMessageCallProcessor.java 0.00% 1 Missing ⚠️
...p/service/contract/impl/state/ProxyEvmAccount.java 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##             release/0.51   #13668       +/-   ##
===================================================
+ Coverage                0   67.57%   +67.57%     
- Complexity              0    36389    +36389     
===================================================
  Files                   0     3717     +3717     
  Lines                   0   149480   +149480     
  Branches                0    15557    +15557     
===================================================
+ Hits                    0   101011   +101011     
- Misses                  0    44100    +44100     
- Partials                0     4369     +4369     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 4, 2024

Node: HAPI Test (Token) Results

 20 files   20 suites   6m 6s ⏱️
257 tests 257 ✅ 0 💤 0 ❌
260 runs  260 ✅ 0 💤 0 ❌

Results for commit 8645fb4.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jun 4, 2024

Node: HAPI Test (Restart) Results

3 tests   3 ✅  6m 12s ⏱️
3 suites  0 💤
3 files    0 ❌

Results for commit 8645fb4.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jun 4, 2024

Node: HAPI Test (Node Death Reconnect) Results

3 tests   3 ✅  6m 17s ⏱️
3 suites  0 💤
3 files    0 ❌

Results for commit 8645fb4.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jun 4, 2024

Node: HAPI Test (Smart Contract) Results

 68 files   68 suites   23m 45s ⏱️
609 tests 609 ✅ 0 💤 0 ❌
637 runs  637 ✅ 0 💤 0 ❌

Results for commit 8645fb4.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jun 4, 2024

Node: HAPI Test (Time Consuming) Results

19 tests   19 ✅  21m 36s ⏱️
 4 suites   0 💤
 4 files     0 ❌

Results for commit 8645fb4.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jun 4, 2024

Node: HAPI Test (Misc) Results

 51 files   51 suites   23m 36s ⏱️
357 tests 357 ✅ 0 💤 0 ❌
374 runs  374 ✅ 0 💤 0 ❌

Results for commit 8645fb4.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jun 4, 2024

Node: HAPI Test (Crypto) Results

 23 files   23 suites   12m 17s ⏱️
350 tests 350 ✅ 0 💤 0 ❌
356 runs  356 ✅ 0 💤 0 ❌

Results for commit 8645fb4.

♻️ This comment has been updated with latest results.

@lukelee-sl lukelee-sl changed the base branch from develop to release/0.51 June 5, 2024 15:30
Copy link
Contributor

@david-bakin-sl david-bakin-sl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And includes "[feat: remove max gas pure check]" b2294fa #13648

LGTM

Copy link
Contributor

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tyvm @lukelee-sl !

@iwsimon iwsimon merged commit 4fa87b3 into release/0.51 Jun 5, 2024
45 checks passed
@iwsimon iwsimon deleted the cherry-pick-13479 branch June 5, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants