Skip to content

fix: failing test due to typo for NegativeHtsTransferFrom contract #12596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

MrValioBg
Copy link
Contributor

@MrValioBg MrValioBg commented Apr 5, 2024

Description:
Fixes typo which resulted in Hapi test failing.

Related issue(s):

Fixes #12417

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Valentin Valkanov <[email protected]>
@MrValioBg MrValioBg added the Limechain Work planned for the LimeChain team label Apr 5, 2024
@MrValioBg MrValioBg self-assigned this Apr 5, 2024
@MrValioBg MrValioBg requested a review from a team April 5, 2024 12:54
@MrValioBg MrValioBg requested a review from a team as a code owner April 5, 2024 12:54
Copy link

github-actions bot commented Apr 5, 2024

Node: HAPI Test (Node Death Reconnect) Results

1 tests   1 ✅  24s ⏱️
1 suites  0 💤
2 files    0 ❌
1 errors

For more details on these parsing errors, see this check.

Results for commit 822c0b7.

Copy link

github-actions bot commented Apr 5, 2024

Node: HAPI Test (Restart) Results

2 tests   2 ✅  7m 12s ⏱️
2 suites  0 💤
2 files    0 ❌

Results for commit 822c0b7.

Copy link

github-actions bot commented Apr 5, 2024

Node: HAPI Test (Token) Results

207 tests   207 ✅  20m 58s ⏱️
 16 suites    0 💤
 16 files      0 ❌

Results for commit 822c0b7.

Copy link

github-actions bot commented Apr 5, 2024

Node: HAPI Test (Crypto) Results

311 tests   311 ✅  42m 7s ⏱️
 25 suites    0 💤
 25 files      0 ❌

Results for commit 822c0b7.

Copy link

github-actions bot commented Apr 5, 2024

Node: HAPI Test (Misc) Results

433 tests   423 ✅  42m 0s ⏱️
 75 suites   10 💤
 75 files      0 ❌

Results for commit 822c0b7.

Copy link

github-actions bot commented Apr 5, 2024

Node: HAPI Test (Time Consuming) Results

21 tests   21 ✅  54m 21s ⏱️
 3 suites   0 💤
 3 files     0 ❌

Results for commit 822c0b7.

Copy link

github-actions bot commented Apr 5, 2024

Node: Unit Test Results

  2 273 files  ±0    2 273 suites  ±0   3h 0m 34s ⏱️ - 1h 0m 0s
112 220 tests ±0  112 124 ✅ ±0  96 💤 ±0  0 ❌ ±0 
120 702 runs  ±0  120 605 ✅ ±0  97 💤 ±0  0 ❌ ±0 

Results for commit 822c0b7. ± Comparison against base commit d28e001.

This pull request removes 3962 and adds 3733 tests. Note that renamed tests count towards both.

  
             IssuerDN: CN=s-aaaa
            SubjectDN: CN=s-aaaa
           Final Date: Fri Jan 01 00:00:00 UTC 2100
           Public Key: RSA Public Key [2e:28:bc:1e:d3:83:25:92:8e:cb:98:b1:b6:84:06:9c:d5:d8:14:d5],[56:66:d1:a4]
           Start Date: Sat Jan 01 00:00:00 UTC 2000
         SerialNumber: 12482092706667292405
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5…
   Address[id=0,nickname=Austin,selfName=aaaa,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=30819,hostnameExternal=210.95.31.178,portExternalIpv4=11685,sigPublicKey=<null>,agreePublicKey=<null>,sigCert=com.swirlds.platform.crypto.SerializableX509Certificate@747f79eb,agreeCert=com.swirlds.platform.crypto.SerializableX509Certificate@6d208cb2,memo=3QtlbXhpSb],
…
com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [4] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [6] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [7]   
  
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [10] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@8fdd3cd2
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [11] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@6164a99a
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [12] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@23ee811b
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [13] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@821d7a5e
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [14] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@65306a3e
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [15] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@dd8d8c9d
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [16] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@2825f3d4
…

Copy link

github-actions bot commented Apr 5, 2024

Node: HAPI Test (Smart Contract) Results

550 tests   550 ✅  1h 12m 22s ⏱️
 60 suites    0 💤
 60 files      0 ❌

Results for commit 822c0b7.

Copy link
Contributor

@netopyr netopyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @MrValioBg

@netopyr netopyr merged commit 969dd79 into develop Apr 8, 2024
53 of 54 checks passed
@netopyr netopyr deleted the 012417-fix-failing-hapi-test-typo branch April 8, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Limechain Work planned for the LimeChain team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement negative test cases for transferFrom and transferFromNFT system contracts
4 participants