Skip to content

fix: Fix schedules during replay #12585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

Neeharika-Sompalli
Copy link
Contributor

Related to #12334

  • Fixes duplicated schedules list in SchedulesByEquality Map
  • Fixes dumpers to dump schedules

Signed-off-by: Neeharika-Sompalli <[email protected]>
@Neeharika-Sompalli Neeharika-Sompalli requested a review from a team April 5, 2024 04:35
@Neeharika-Sompalli Neeharika-Sompalli requested a review from a team as a code owner April 5, 2024 04:35
@Neeharika-Sompalli Neeharika-Sompalli self-assigned this Apr 5, 2024
Copy link

github-actions bot commented Apr 5, 2024

Node: HAPI Test (Restart) Results

2 tests   2 ✔️  6m 10s ⏱️
2 suites  0 💤
2 files    0

Results for commit 13e6bd2.

Copy link

github-actions bot commented Apr 5, 2024

Node: HAPI Test (Node Death Reconnect) Results

2 tests   2 ✔️  6m 58s ⏱️
2 suites  0 💤
2 files    0

Results for commit 13e6bd2.

Copy link

github-actions bot commented Apr 5, 2024

Node: HAPI Test (Token) Results

207 tests   207 ✔️  19m 26s ⏱️
  16 suites      0 💤
  16 files        0

Results for commit 13e6bd2.

Copy link

github-actions bot commented Apr 5, 2024

Node: HAPI Test (Crypto) Results

216 tests   216 ✔️  24m 0s ⏱️
  23 suites      0 💤
  23 files        0

Results for commit 13e6bd2.

Copy link

github-actions bot commented Apr 5, 2024

Node: HAPI Test (Misc) Results

432 tests   422 ✔️  38m 49s ⏱️
  75 suites    10 💤
  75 files        0

Results for commit 13e6bd2.

Copy link

github-actions bot commented Apr 5, 2024

Node: HAPI Test (Time Consuming) Results

21 tests   21 ✔️  54m 8s ⏱️
  3 suites    0 💤
  3 files      0

Results for commit 13e6bd2.

Copy link

github-actions bot commented Apr 5, 2024

Node: HAPI Test (Smart Contract) Results

497 tests   494 ✔️  1h 3m 29s ⏱️
  55 suites      3 💤
  55 files        0

Results for commit 13e6bd2.

Copy link

github-actions bot commented Apr 5, 2024

Node: Unit Test Results

    2 264 files  ±0      2 264 suites  ±0   2h 29m 59s ⏱️ - 20m 5s
112 190 tests +1  112 141 ✔️ +1  49 💤 ±0  0 ±0 
120 651 runs  +1  120 602 ✔️ +1  49 💤 ±0  0 ±0 

Results for commit 13e6bd2. ± Comparison against base commit a8bc1ae.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 36.73469% with 31 lines in your changes are missing coverage. Please review.

Project coverage is 61.02%. Comparing base (a8bc1ae) to head (13e6bd2).
Report is 6 commits behind head on release/0.48.

Files Patch % Lines
...edtransactions/ScheduledTransactionsDumpUtils.java 0.00% 25 Missing ⚠️
...edtransactions/ScheduledTransactionsDumpUtils.java 0.00% 6 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##             release/0.48   #12585      +/-   ##
==================================================
- Coverage           61.03%   61.02%   -0.02%     
+ Complexity          30817    30815       -2     
==================================================
  Files                3443     3443              
  Lines              141274   141293      +19     
  Branches            14753    14753              
==================================================
- Hits                86227    86219       -8     
- Misses              51260    51291      +31     
+ Partials             3787     3783       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@netopyr netopyr changed the title Fix schedules during replay fix: Fix schedules during replay Apr 5, 2024
Copy link
Contributor

@iwsimon iwsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @Neeharika-Sompalli

Copy link
Contributor

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tyvm @Neeharika-Sompalli !

@Neeharika-Sompalli Neeharika-Sompalli merged commit ebe16e0 into release/0.48 Apr 5, 2024
46 of 53 checks passed
@Neeharika-Sompalli Neeharika-Sompalli deleted the schedule-replay-fixes branch April 5, 2024 18:06
netopyr added a commit that referenced this pull request Apr 5, 2024
* release/0.48:
  fix: fixed diff test issue 12509 (#12597)
  fix: Set minimum staking to 0 (#12601)
  fix: Fix schedules during replay (#12585)
Neeharika-Sompalli added a commit that referenced this pull request Apr 11, 2024
Neeharika-Sompalli added a commit that referenced this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants