Skip to content

fix: use 0 for unset auto-renew period #12577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Conversation

tinker-michaelj
Copy link
Contributor

@tinker-michaelj tinker-michaelj commented Apr 4, 2024

@tinker-michaelj tinker-michaelj requested a review from a team as a code owner April 4, 2024 21:07
Copy link

github-actions bot commented Apr 4, 2024

Node: HAPI Test (Restart) Results

2 tests   2 ✅  5m 30s ⏱️
2 suites  0 💤
2 files    0 ❌

Results for commit db41313.

Copy link

github-actions bot commented Apr 4, 2024

Node: HAPI Test (Node Death Reconnect) Results

1 tests   1 ✅  27s ⏱️
1 suites  0 💤
2 files    0 ❌
1 errors

For more details on these parsing errors, see this check.

Results for commit db41313.

Copy link

github-actions bot commented Apr 4, 2024

Node: HAPI Test (Token) Results

207 tests   207 ✅  19m 7s ⏱️
 16 suites    0 💤
 16 files      0 ❌

Results for commit db41313.

Copy link

github-actions bot commented Apr 4, 2024

Node: HAPI Test (Misc) Results

433 tests   423 ✅  41m 44s ⏱️
 75 suites   10 💤
 75 files      0 ❌

Results for commit db41313.

Copy link

github-actions bot commented Apr 4, 2024

Node: HAPI Test (Crypto) Results

311 tests   311 ✅  45m 56s ⏱️
 25 suites    0 💤
 25 files      0 ❌

Results for commit db41313.

Copy link

github-actions bot commented Apr 4, 2024

Node: HAPI Test (Time Consuming) Results

21 tests   21 ✅  53m 55s ⏱️
 3 suites   0 💤
 3 files     0 ❌

Results for commit db41313.

Copy link

github-actions bot commented Apr 4, 2024

Node: Unit Test Results

  2 273 files  ±0    2 273 suites  ±0   2h 41m 44s ⏱️ - 1h 11m 56s
112 219 tests ±0  112 123 ✅ ±0  96 💤 ±0  0 ❌ ±0 
120 701 runs  ±0  120 604 ✅ ±0  97 💤 ±0  0 ❌ ±0 

Results for commit db41313. ± Comparison against base commit 62d0dc6.

This pull request removes 3975 and adds 3745 tests. Note that renamed tests count towards both.

  
             IssuerDN: CN=s-aaaa
            SubjectDN: CN=s-aaaa
           Final Date: Fri Jan 01 00:00:00 UTC 2100
           Public Key: RSA Public Key [2e:28:bc:1e:d3:83:25:92:8e:cb:98:b1:b6:84:06:9c:d5:d8:14:d5],[56:66:d1:a4]
           Start Date: Sat Jan 01 00:00:00 UTC 2000
         SerialNumber: 12482092706667292405
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5e…
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5…
…
com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [4] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [6] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [7]   
  
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [10] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@55e0bfff
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [11] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@8d5e9d81
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [12] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@1a4b30eb
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [13] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@e96403cf
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [14] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@571c48d8
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [15] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@cb7f19f3
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [16] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@1f39f06b
…

Copy link

github-actions bot commented Apr 4, 2024

Node: HAPI Test (Smart Contract) Results

550 tests   549 ✅  1h 12m 7s ⏱️
 60 suites    0 💤
 60 files      1 ❌

For more details on these failures, see this check.

Results for commit db41313.

Copy link
Contributor

@lukelee-sl lukelee-sl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Neeharika-Sompalli Neeharika-Sompalli merged commit a2a4c92 into develop Apr 5, 2024
@Neeharika-Sompalli Neeharika-Sompalli deleted the cherry-pick-12576 branch April 5, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(3/27 19:15) Mismatched values, expected 'SUCCESS', got 'CONTRACT_REVERT_EXECUTED'
3 participants