Skip to content

fix: Add pure check to ContractDeleteHandler #12574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 5, 2024
Merged

fix: Add pure check to ContractDeleteHandler #12574

merged 1 commit into from
Apr 5, 2024

Conversation

netopyr
Copy link
Contributor

@netopyr netopyr commented Apr 4, 2024 •
edited by Neeharika-Sompalli
Loading

Fixes #12565
Add pureChecks() to ContractDeleteHandler to ensure mandatory contractID is provided.

@netopyr netopyr added this to the v0.48 milestone Apr 4, 2024
@netopyr netopyr self-assigned this Apr 4, 2024
@netopyr netopyr requested review from tinker-michaelj and a team as code owners April 4, 2024 20:53
@netopyr netopyr requested a review from david-bakin-sl April 4, 2024 20:53
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 4, 2024

Node: HAPI Test (Restart) Results

2 tests   2 ✔️  6m 5s ⏱️
2 suites  0 💤
2 files    0 ❌

Results for commit df95aa2.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 4, 2024

Node: HAPI Test (Node Death Reconnect) Results

2 tests   2 ✔️  7m 4s ⏱️
2 suites  0 💤
2 files    0 ❌

Results for commit df95aa2.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 4, 2024

Node: HAPI Test (Token) Results

207 tests   207 ✔️  19m 12s ⏱️
  16 suites      0 💤
  16 files        0 ❌

Results for commit df95aa2.

tinker-michaelj
tinker-michaelj approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ty @netopyr !

david-bakin-sl
david-bakin-sl approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@david-bakin-sl david-bakin-sl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 4, 2024 •
edited
Loading

Node: HAPI Test (Crypto) Results

215 tests   215 ✔️  22m 48s ⏱️
  23 suites      0 💤
  23 files        0 ❌

Results for commit df95aa2.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 4, 2024

Node: HAPI Test (Misc) Results

432 tests   422 ✔️  38m 42s ⏱️
  75 suites    10 💤
  75 files        0 ❌

Results for commit df95aa2.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 4, 2024

Node: HAPI Test (Time Consuming) Results

21 tests   21 ✔️  53m 44s ⏱️
  3 suites    0 💤
  3 files      0 ❌

Results for commit df95aa2.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 4, 2024

Node: HAPI Test (Smart Contract) Results

497 tests   494 ✔️  1h 3m 19s ⏱️
  55 suites      3 💤
  55 files        0 ❌

Results for commit df95aa2.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 5, 2024

Node: Unit Test Results

    2 264 files  ±0      2 264 suites  ±0   3h 33m 12s ⏱️ - 37m 1s
112 189 tests ±0  112 140 ✔️ ±0  49 💤 ±0  0 ❌ ±0 
120 650 runs  ±0  120 601 ✔️ ±0  49 💤 ±0  0 ❌ ±0 

Results for commit df95aa2. ± Comparison against base commit 86668c7.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 61.02%. Comparing base (86668c7) to head (df95aa2).
Report is 5 commits behind head on release/0.48.

Files Patch % Lines
.../contract/impl/handlers/ContractDeleteHandler.java 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@                Coverage Diff                 @@
##             release/0.48   #12574      +/-   ##
==================================================
- Coverage           61.02%   61.02%   -0.01%     
- Complexity          30812    30813       +1     
==================================================
  Files                3443     3443              
  Lines              141261   141264       +3     
  Branches            14750    14750              
==================================================
- Hits                86211    86210       -1     
- Misses              51269    51274       +5     
+ Partials             3781     3780       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@netopyr netopyr merged commit a69e274 into release/0.48 Apr 5, 2024
51 of 52 checks passed
@netopyr netopyr deleted the 12565-fix-contract-id-npe branch April 5, 2024 06:37
netopyr added a commit that referenced this pull request Apr 8, 2024
@netopyr
fix: Add pure check to ContractDeleteHandler (#12574)
c360acb 
Signed-off-by: Michael Heinrichs <[email protected]>
(cherry picked from commit a69e274)
@netopyr netopyr mentioned this pull request Apr 8, 2024
Merged
@poulok poulok modified the milestones: v0.48, v0.49 Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tinker-michaelj tinker-michaelj tinker-michaelj approved these changes

@Neeharika-Sompalli Neeharika-Sompalli Neeharika-Sompalli approved these changes

@david-bakin-sl david-bakin-sl david-bakin-sl approved these changes

Assignees

@netopyr netopyr

Labels
None yet
Projects
None yet
Milestone
v0.49
Development

Successfully merging this pull request may close these issues.
6 participants
@netopyr @codecov-commenter @tinker-michaelj @Neeharika-Sompalli @david-bakin-sl @poulok