Skip to content

feat(ReconnectBench): fuzz slow I/O delay emulation #12544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

anthony-swirldslabs
Copy link
Contributor

Description:
Introducing a LongFuzzer and using it to fuzz the emulated storage and network I/O delays in the ReconnectBench. The fuzz amount is configured in the form of a percentage range around the base value of the delay. I'm using the original and a negative Random seed values for the storage and network delays fuzzers correspondingly to make the fuzz amounts different between the two.

Related issue(s):

Fixes #12343

Notes for reviewer:

$ gr jmhReconnect
...
Benchmark                 (delayNetworkFuzzRangePercent)  (delayNetworkMicroseconds)  (delayStorageFuzzRangePercent)  (delayStorageMicroseconds)  (keySize)  (maxKey)  (numFiles)  (numRecords)  (numThreads)  (randomSeed)  (recordSize)  (teacherAddProbability)  (teacherModifyProbability)  (teacherRemoveProbability)  Mode  Cnt  Score   Error  Units
ReconnectBench.reconnect                            0.15                          50                            0.15                         100          8   1000000         100          1000            32    9823452658           128                     0.01                        0.01                        0.01  avgt    7  4.777 ± 0.528   s/op

Benchmark result is saved to /Users/anthony/ws/15-jmh/hedera-services/platform-sdk/swirlds-benchmarks/build/results/jmh/results-reconnect.txt

BUILD SUCCESSFUL in 2m 19s

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Copy link

github-actions bot commented Apr 4, 2024

Node: HAPI Test (Restart) Results

2 tests   2 ✅  5m 38s ⏱️
2 suites  0 💤
2 files    0 ❌

Results for commit e9d2a29.

Copy link

github-actions bot commented Apr 4, 2024

Node: HAPI Test (Node Death Reconnect) Results

1 tests   1 ✅  20s ⏱️
1 suites  0 💤
2 files    0 ❌
1 errors

For more details on these parsing errors, see this check.

Results for commit e9d2a29.

Copy link

github-actions bot commented Apr 4, 2024

Node: HAPI Test (Token) Results

207 tests   207 ✅  22m 9s ⏱️
 16 suites    0 💤
 16 files      0 ❌

Results for commit e9d2a29.

Copy link

github-actions bot commented Apr 4, 2024

Node: HAPI Test (Misc) Results

433 tests   423 ✅  41m 12s ⏱️
 75 suites   10 💤
 75 files      0 ❌

Results for commit e9d2a29.

Copy link

github-actions bot commented Apr 4, 2024

Node: HAPI Test (Crypto) Results

311 tests   311 ✅  45m 34s ⏱️
 25 suites    0 💤
 25 files      0 ❌

Results for commit e9d2a29.

Copy link

github-actions bot commented Apr 4, 2024

Node: HAPI Test (Time Consuming) Results

21 tests   21 ✅  54m 43s ⏱️
 3 suites   0 💤
 3 files     0 ❌

Results for commit e9d2a29.

Copy link

github-actions bot commented Apr 4, 2024

Node: Unit Test Results

  2 271 files  ±0    2 271 suites  ±0   3h 30m 6s ⏱️ + 1h 35m 22s
112 213 tests ±0  112 117 ✅ ±0  96 💤 ±0  0 ❌ ±0 
120 695 runs  ±0  120 598 ✅ ±0  97 💤 ±0  0 ❌ ±0 

Results for commit e9d2a29. ± Comparison against base commit 682841e.

This pull request removes 3955 and adds 3725 tests. Note that renamed tests count towards both.

  
             IssuerDN: CN=s-aaaa
            SubjectDN: CN=s-aaaa
           Final Date: Fri Jan 01 00:00:00 UTC 2100
           Public Key: RSA Public Key [2e:28:bc:1e:d3:83:25:92:8e:cb:98:b1:b6:84:06:9c:d5:d8:14:d5],[56:66:d1:a4]
           Start Date: Sat Jan 01 00:00:00 UTC 2000
         SerialNumber: 12482092706667292405
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5…
   Address[id=0,nickname=Austin,selfName=aaaa,weight=1000,hostnameInternal=127.0.0.1,portInternalIpv4=15433,hostnameExternal=80.140.94.184,portExternalIpv4=11633,sigPublicKey=<null>,agreePublicKey=<null>,sigCert=com.swirlds.platform.crypto.SerializableX509Certificate@1f474cbe,agreeCert=com.swirlds.platform.crypto.SerializableX509Certificate@25a1888,memo=CDekukOgS3],
…
com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [4] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [6] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [7]   
  
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [10] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@9fdddbec
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [11] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@29f59572
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [12] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@b9d24e56
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [13] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@c477d2a0
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [14] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@b428350f
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [15] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@46a33135
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [16] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@5852e70a
…

Copy link

github-actions bot commented Apr 4, 2024

Node: HAPI Test (Smart Contract) Results

521 tests   521 ✅  1h 7m 32s ⏱️
 57 suites    0 💤
 57 files      0 ❌

Results for commit e9d2a29.

@anthony-swirldslabs anthony-swirldslabs merged commit c781d6b into develop Apr 4, 2024
@anthony-swirldslabs anthony-swirldslabs deleted the issue-12343-1 branch April 4, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fuzz slow I/O delay in ReconnectBench
4 participants