fix: Fix issues found during replaying events and dumping state #12531

Neeharika-Sompalli · 2024-04-03T16:14:41Z

Fixes #12334

Fixed NPEs in dumpers
Changed to not use NftID.DEFAULT in any migration code as key
Changed all stores in. token service to add a check when put into state to have key that is not DEFAULT
Added StateDumper to dump all three schedule virtual maps. Actual Dumping and validating scheduled state will be done in next PR
Fixed token relation linkedLists in NFTOwnerChangesStep

Signed-off-by: Neeharika-Sompalli <[email protected]>

github-actions · 2024-04-03T18:02:32Z

Node: HAPI Test (Time Consuming) Results

21 tests 21 ✔️ 54m 11s ⏱️
  3 suites   0 💤
  3 files   0 ❌

Results for commit 1c07fc4.

♻️ This comment has been updated with latest results.

github-actions · 2024-04-03T18:12:08Z

Node: HAPI Test (Smart Contract) Results

497 tests 494 ✔️ 1h 4m 18s ⏱️
  55 suites     3 💤
  55 files     0 ❌

Results for commit 1c07fc4.

♻️ This comment has been updated with latest results.

github-actions · 2024-04-03T18:25:59Z

Node: Unit Test Results

    2 264 files ±0     2 264 suites ±0 3h 9m 4s ⏱️ + 22m 38s
112 188 tests ±0 112 139 ✔️ ±0 49 💤 ±0 0 ❌ ±0
120 649 runs ±0 120 600 ✔️ ±0 49 💤 ±0 0 ❌ ±0

Results for commit 1c07fc4. ± Comparison against base commit 409ac89.

♻️ This comment has been updated with latest results.

Signed-off-by: Neeharika-Sompalli <[email protected]>

Signed-off-by: Michael Tinker <[email protected]> Signed-off-by: Neeharika-Sompalli <[email protected]>

Signed-off-by: Neeharika-Sompalli <[email protected]>

codecov-commenter · 2024-04-03T20:36:22Z

Codecov Report

Attention: Patch coverage is 33.78840% with 194 lines in your changes are missing coverage. Please review.

Project coverage is 61.03%. Comparing base (409ac89) to head (1c07fc4).

Files	Patch %	Lines
...edtransactions/ScheduledTransactionsDumpUtils.java	0.00%	59 Missing ⚠️
...scheduledtransactions/BBMScheduledSecondValue.java	0.00%	19 Missing ⚠️
...edtransactions/ScheduledTransactionsDumpUtils.java	0.00%	16 Missing ⚠️
.../impl/schemas/InitialModServiceScheduleSchema.java	0.00%	16 Missing ⚠️
...heduledtransactions/BBMScheduledEqualityValue.java	0.00%	14 Missing ⚠️
...en/impl/handlers/transfer/NFTOwnersChangeStep.java	76.36%	10 Missing and 3 partials ⚠️
...e/mono/state/migration/AccountStateTranslator.java	45.45%	11 Missing and 1 partial ⚠️
.../com/hedera/node/app/statedumpers/StateDumper.java	0.00%	6 Missing ⚠️
...de/app/service/token/impl/RecordFinalizerBase.java	44.44%	1 Missing and 4 partials ⚠️
...a/node/app/workflows/handle/HandleContextImpl.java	0.00%	3 Missing and 1 partial ⚠️
... and 14 more

Additional details and impacted files

@@                Coverage Diff                 @@
##             release/0.48   #12531      +/-   ##
==================================================
- Coverage           61.04%   61.03%   -0.01%     
- Complexity          30806    30817      +11     
==================================================
  Files                3443     3443              
  Lines              141133   141259     +126     
  Branches            14736    14749      +13     
==================================================
+ Hits                86151    86217      +66     
- Misses              51211    51260      +49     
- Partials             3771     3782      +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Neeharika-Sompalli <[email protected]>

...e/src/main/java/com/hedera/node/app/service/mono/state/migration/AccountStateTranslator.java

...n-service-impl/src/main/java/com/hedera/node/app/service/token/impl/RecordFinalizerBase.java

...-service-impl/src/main/java/com/hedera/node/app/service/token/impl/WritableAccountStore.java

tinker-michaelj

LGTM, tyvm @Neeharika-Sompalli !

Signed-off-by: Neeharika-Sompalli <[email protected]>

iwsimon

LGTM. Thanks @Neeharika-Sompalli

tinker-michaelj

LGTM, ty @Neeharika-Sompalli !

Signed-off-by: Neeharika-Sompalli <[email protected]> Signed-off-by: Michael Tinker <[email protected]> Co-authored-by: Michael Tinker <[email protected]> Signed-off-by: Neeharika-Sompalli <[email protected]>

Signed-off-by: Neeharika-Sompalli <[email protected]>

…ng state (#12531) (#12560) Signed-off-by: Neeharika-Sompalli <[email protected]> Signed-off-by: Michael Tinker <[email protected]> Co-authored-by: Michael Tinker <[email protected]>

Neeharika-Sompalli and others added 30 commits March 20, 2024 15:18

move mono dumpers to mono service

3c0b6fb

Signed-off-by: Neeharika-Sompalli <[email protected]>

move mono dumpers to mono service

f5bba91

Signed-off-by: Neeharika-Sompalli <[email protected]>

fix issues

76d8fe6

Signed-off-by: Neeharika-Sompalli <[email protected]>

fix issues

0adde53

Signed-off-by: Neeharika-Sompalli <[email protected]>

fix issues

2cf9de4

Signed-off-by: Neeharika-Sompalli <[email protected]>

fix issues

f731f8b

Signed-off-by: Neeharika-Sompalli <[email protected]>

fix issues

bf522a9

Signed-off-by: Neeharika-Sompalli <[email protected]>

fix issues

182c028

Signed-off-by: Neeharika-Sompalli <[email protected]>

fix issues

22217ac

Signed-off-by: Neeharika-Sompalli <[email protected]>

refactor

90baeea

Signed-off-by: Neeharika-Sompalli <[email protected]>

refactor

d06dfaa

Signed-off-by: Neeharika-Sompalli <[email protected]>

refactor

9433c01

Signed-off-by: Neeharika-Sompalli <[email protected]>

refactor

0a658a5

Signed-off-by: Neeharika-Sompalli <[email protected]>

Merge branch 'release/0.48' into 12232-token-service-state-validation

71e3cd2

fix some issues

5e37e5d

Signed-off-by: Neeharika-Sompalli <[email protected]>

fix some issues

8bddf6b

Signed-off-by: Neeharika-Sompalli <[email protected]>

spotless

acaa839

Signed-off-by: Neeharika-Sompalli <[email protected]>

remove unnecessary files

d93840c

Signed-off-by: Neeharika-Sompalli <[email protected]>

fix migration issues

4dc3b51

Signed-off-by: Neeharika-Sompalli <[email protected]>

spotless

57b4d12

Signed-off-by: Neeharika-Sompalli <[email protected]>

wip

a02ab61

Signed-off-by: Neeharika-Sompalli <[email protected]>

wip

41d64dc

Signed-off-by: Neeharika-Sompalli <[email protected]>

Merge branch 'release/0.48' into 12333-migration-fixes

f60e225

Signed-off-by: Neeharika-Sompalli <[email protected]>

FIX ISSUES

3e91fac

Signed-off-by: Neeharika-Sompalli <[email protected]>

spotless

0ea5502

Signed-off-by: Neeharika-Sompalli <[email protected]>

fix unit test

c9e830f

Signed-off-by: Neeharika-Sompalli <[email protected]>

fix review comment

1db3862

Signed-off-by: Neeharika-Sompalli <[email protected]>

fix wip

3808567

Signed-off-by: Neeharika-Sompalli <[email protected]>

fix wip

84176e3

Signed-off-by: Neeharika-Sompalli <[email protected]>

fix wip

7e90278

Signed-off-by: Neeharika-Sompalli <[email protected]>

Neeharika-Sompalli and others added 2 commits April 3, 2024 15:02

update records

7d3b193

Signed-off-by: Neeharika-Sompalli <[email protected]>

fix: finalize stake metadata only once per transaction (#12537)

09c2bad

Signed-off-by: Michael Tinker <[email protected]> Signed-off-by: Neeharika-Sompalli <[email protected]>

Neeharika-Sompalli dismissed iwsimon’s stale review via 09c2bad April 3, 2024 20:04

fix next pointers

7ed0618

Signed-off-by: Neeharika-Sompalli <[email protected]>

fix unit test

707671c

Signed-off-by: Neeharika-Sompalli <[email protected]>

Neeharika-Sompalli requested a review from iwsimon April 3, 2024 21:33

Neeharika-Sompalli added 3 commits April 3, 2024 18:26

fix unit tests

edbb202

Signed-off-by: Neeharika-Sompalli <[email protected]>

fix unit tests

e3fe118

Signed-off-by: Neeharika-Sompalli <[email protected]>

Merge branch 'release/0.48' into 12334-replay-fixes

1e9948c

tinker-michaelj reviewed Apr 4, 2024

View reviewed changes

...e/src/main/java/com/hedera/node/app/service/mono/state/migration/AccountStateTranslator.java Show resolved Hide resolved

tinker-michaelj reviewed Apr 4, 2024

View reviewed changes

...n-service-impl/src/main/java/com/hedera/node/app/service/token/impl/RecordFinalizerBase.java Show resolved Hide resolved

tinker-michaelj reviewed Apr 4, 2024

View reviewed changes

...-service-impl/src/main/java/com/hedera/node/app/service/token/impl/WritableAccountStore.java Show resolved Hide resolved

tinker-michaelj previously approved these changes Apr 4, 2024

View reviewed changes

fix unit tests

6f1853d

Signed-off-by: Neeharika-Sompalli <[email protected]>

Neeharika-Sompalli dismissed tinker-michaelj’s stale review via 6f1853d April 4, 2024 04:16

Neeharika-Sompalli added 2 commits April 3, 2024 23:39

fix unit tests

fa8a4e9

Signed-off-by: Neeharika-Sompalli <[email protected]>

fix precheck

1c07fc4

Signed-off-by: Neeharika-Sompalli <[email protected]>

iwsimon approved these changes Apr 4, 2024

View reviewed changes

tinker-michaelj approved these changes Apr 4, 2024

View reviewed changes

Neeharika-Sompalli merged commit 6b0f999 into release/0.48 Apr 4, 2024
26 checks passed

Neeharika-Sompalli deleted the 12334-replay-fixes branch April 4, 2024 15:18

Neeharika-Sompalli mentioned this pull request Apr 4, 2024

fix: (cherry-pick) Fix issues found during replaying events and dumping state (#12531) #12560

Merged

Neeharika-Sompalli added a commit that referenced this pull request Apr 4, 2024

fix: Fix issues found during replaying events and dumping state (#12531)

13b7dc0

Signed-off-by: Neeharika-Sompalli <[email protected]>

OlegMazurov mentioned this pull request Apr 23, 2024

Warm up more entities #12976

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Fix issues found during replaying events and dumping state #12531

fix: Fix issues found during replaying events and dumping state #12531

Neeharika-Sompalli commented Apr 3, 2024 •

edited

Loading

github-actions bot commented Apr 3, 2024 •

edited

Loading

github-actions bot commented Apr 3, 2024 •

edited

Loading

github-actions bot commented Apr 3, 2024 •

edited

Loading

codecov-commenter commented Apr 3, 2024 •

edited

Loading

tinker-michaelj left a comment

iwsimon left a comment

tinker-michaelj left a comment

fix: Fix issues found during replaying events and dumping state #12531

fix: Fix issues found during replaying events and dumping state #12531

Conversation

Neeharika-Sompalli commented Apr 3, 2024 • edited Loading

github-actions bot commented Apr 3, 2024 • edited Loading

Node: HAPI Test (Time Consuming) Results

github-actions bot commented Apr 3, 2024 • edited Loading

Node: HAPI Test (Smart Contract) Results

github-actions bot commented Apr 3, 2024 • edited Loading

Node: Unit Test Results

codecov-commenter commented Apr 3, 2024 • edited Loading

Codecov Report

tinker-michaelj left a comment

Choose a reason for hiding this comment

iwsimon left a comment

Choose a reason for hiding this comment

tinker-michaelj left a comment

Choose a reason for hiding this comment

Neeharika-Sompalli commented Apr 3, 2024 •

edited

Loading

github-actions bot commented Apr 3, 2024 •

edited

Loading

github-actions bot commented Apr 3, 2024 •

edited

Loading

github-actions bot commented Apr 3, 2024 •

edited

Loading

codecov-commenter commented Apr 3, 2024 •

edited

Loading