Skip to content

feat: Create Simulator Test Framework with Fixtures #1393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

mustafauzunn
Copy link
Contributor

@mustafauzunn mustafauzunn commented Jul 14, 2025

Reviewer Notes

Currently, we lack fixtures for the simulator, which limits our ability to write comprehensive tests.
Create a small testing initial framework with fixtures. With the effort here I aim mainly to introduce the fixtures, where in future ones we will refine it, according to needs.

  • Create testFixtures in simulator
  • Create TestBlockStreamManager in testFixtures to use getNextBlock
  • Create BlockBuilder in testFixtures to handle block creation
  • Move TestUtils to testFixtures
  • Refactor some tests with TestBlockStreamManager and BlockBuilder
  • Refactor some test mock configs with real configs

Related Issue(s)

Fixes #1333

Signed-off-by: Mustafa Uzun <[email protected]>
Signed-off-by: Mustafa Uzun <[email protected]>
Signed-off-by: Mustafa Uzun <[email protected]>
@ata-nas ata-nas added the pull request label to get past the "label required" check when no label is needed or appropriate. label Jul 14, 2025
@ata-nas ata-nas added this to the 0.15.0 milestone Jul 14, 2025
Signed-off-by: Mustafa Uzun <[email protected]>
@mustafauzunn mustafauzunn marked this pull request as ready for review July 15, 2025 09:44
@mustafauzunn mustafauzunn requested review from a team as code owners July 15, 2025 09:44
@mustafauzunn mustafauzunn requested a review from jasperpotts July 15, 2025 09:44
Copy link

codecov bot commented Jul 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

@@             Coverage Diff              @@
##               main    #1393      +/-   ##
============================================
+ Coverage     80.93%   81.17%   +0.24%     
- Complexity      968      993      +25     
============================================
  Files           112      113       +1     
  Lines          4358     4457      +99     
  Branches        451      467      +16     
============================================
+ Hits           3527     3618      +91     
+ Misses          642      634       -8     
- Partials        189      205      +16     

see 18 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request label to get past the "label required" check when no label is needed or appropriate.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Simulator Test Framework with Fixtures
2 participants