Skip to content

docs: add rwalworth as swift sdk maintainer #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 4, 2025
Merged

docs: add rwalworth as swift sdk maintainer #295

merged 4 commits into from
Jun 4, 2025

Conversation

rwalworth
Copy link
Contributor

Description:
This PR adds rwalworth (myself) as a Swift SDK maintainer.

@rwalworth rwalworth requested review from a team as code owners May 15, 2025 17:59
@rwalworth rwalworth requested a review from jeromy-cannon May 15, 2025 17:59
@clowarden CLOWarden
Copy link

clowarden bot commented May 15, 2025

Validation succeeded

✅ The proposed configuration changes are valid!

Configuration changes

Directory

  • rwalworth is no longer a member of team hiero-sdk-swift-committers
  • rwalworth is now a maintainer of team hiero-sdk-swift-maintainers

🔸 Please review the changes detected as they will be applied immediately once this PR is merged 🔸

@hendrikebbers
Copy link
Member

hendrikebbers commented May 15, 2025 •
edited
Loading

This is a PR that needs a voting by @RickyLB, @Sheng-Long, and @SimiHunjan. For details please check https://github.com/hiero-ledger/governance/blob/main/roles-and-groups.md

@rwalworth rwalworth requested review from Sheng-Long and RickyLB May 15, 2025 18:48
@rwalworth rwalworth mentioned this pull request May 16, 2025
Open
@clowarden CLOWarden
Copy link

clowarden bot commented May 20, 2025

Validation succeeded

✅ The proposed configuration changes are valid!

Configuration changes

Directory

  • rwalworth is no longer a member of team hiero-sdk-swift-committers
  • rwalworth is now a maintainer of team hiero-sdk-swift-maintainers

🔸 Please review the changes detected as they will be applied immediately once this PR is merged 🔸

@jwagantall
Copy link
Contributor

@RickyLB, @Sheng-Long, @SimiHunjan

Can we please get your vote?

@hendrikebbers
Copy link
Member

@SimiHunjan approved the PR and I would count that as a +1 vote. 2 weeks end on Thursday. I neither @Sheng-Long or @RickyLB vote against it I will merge the PR on Thursday.

@clowarden CLOWarden
Copy link

clowarden bot commented Jun 2, 2025

Validation succeeded

✅ The proposed configuration changes are valid!

Configuration changes

Directory

  • rwalworth is no longer a member of team hiero-sdk-swift-committers
  • rwalworth is now a maintainer of team hiero-sdk-swift-maintainers

🔸 Please review the changes detected as they will be applied immediately once this PR is merged 🔸

@clowarden CLOWarden
Copy link

clowarden bot commented Jun 3, 2025

Validation succeeded

✅ The proposed configuration changes are valid!

Configuration changes

Directory

  • rwalworth is now a maintainer of team hiero-sdk-swift-maintainers
  • rwalworth is no longer a member of team hiero-sdk-swift-committers

🔸 Please review the changes detected as they will be applied immediately once this PR is merged 🔸

@rwalworth
Copy link
Contributor Author

@hendrikebbers it has been two weeks, can this be merged?

@hendrikebbers hendrikebbers merged commit d93adf3 into hiero-ledger:main Jun 4, 2025
3 checks passed
@hendrikebbers
Copy link
Member

merged

@clowarden CLOWarden
Copy link

clowarden bot commented Jun 4, 2025

Reconciliation completed

✅ The reconciliation completed successfully and all changes have been applied across the services!

Changes applied

Github

  • rwalworth is no longer a member of team hiero-sdk-swift-committers
  • rwalworth is now a maintainer of team hiero-sdk-swift-maintainers

@rwalworth rwalworth deleted the propose-rwalworth-as-swift-sdk-maintainer branch June 5, 2025 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimiHunjan SimiHunjan SimiHunjan approved these changes

@jeromy-cannon jeromy-cannon Awaiting requested review from jeromy-cannon jeromy-cannon is a code owner automatically assigned from hiero-ledger/github-maintainers

@Sheng-Long Sheng-Long Awaiting requested review from Sheng-Long

@RickyLB RickyLB Awaiting requested review from RickyLB

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rwalworth @hendrikebbers @jwagantall @SimiHunjan