Fix for issue #1160: Add logarithm support #2165
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #2165 will not alter performanceComparing Summary
|
|
|
||
| # Case 2: Special handling for adding dimensionless dB to other logarithmic units | ||
| elif ( | ||
| other_non_mul_units[0] == "decibel" |
There was a problem hiding this comment.
can you check for a dimensionless log unit here instead of hard coding decibel?
this case needs a test
|
this is good. thank you for the clear explanatory comments, they make it easy to follow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ability to add dB values in a sensible way. I don't think documentation updates are needed as the behavior is now more intuitive.
pre-commit run --all-fileswith no errors