Skip to content

fix: multiple fixes to how REPL processes argv and autocomplete #3300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 27, 2025
Merged

fix: multiple fixes to how REPL processes argv and autocomplete #3300

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8c4ab9e
fix: multiple fixes to how REPL processes argv and autocomplete
justinwilaby May 22, 2025
2920120
Added --repl flag
justinwilaby May 22, 2025
4df8614
ignore empty lines
justinwilaby May 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/cli/bin/heroku-prompts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,19 +50,19 @@ function filePrompt(description, defaultPath) {
}

const showBooleanPrompt = async (commandFlag, userInputMap, defaultOption) => {
const {description, default: defaultValue, name: flagOrArgName} = commandFlag
const choice = await choicesPrompt(description, [
const {description, name: flagOrArgName} = commandFlag
const {choices} = await choicesPrompt(description, [
{name: 'yes', value: true},
{name: 'no', value: false},
], defaultOption)

// user cancelled
if (choice === undefined || choice === 'Cancel') {
if (choices === undefined || choices === 'Cancel') {
return true
}

if (choice === 'Yes') {
userInputMap.set(flagOrArgName, defaultValue)
if (choices) {
userInputMap.set(flagOrArgName, {input: true})
}

return false
Expand Down
Loading
Loading