Skip to content

Do not print empty/true filters #888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2025
Merged

Do not print empty/true filters #888

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ba5a89
Do not print empty/true filters
hernan-poncedeleon May 16, 2025
1d8a50c
Remove null check
hernan-poncedeleon May 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions dartagnan/src/main/java/com/dat3m/dartagnan/Dartagnan.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
import com.dat3m.dartagnan.encoding.IREvaluator;
import com.dat3m.dartagnan.encoding.ProverWithTracker;
import com.dat3m.dartagnan.expression.ExpressionPrinter;
import com.dat3m.dartagnan.expression.Expression;
import com.dat3m.dartagnan.expression.booleans.BoolLiteral;
import com.dat3m.dartagnan.parsers.cat.ParserCat;
import com.dat3m.dartagnan.parsers.program.ProgramParser;
import com.dat3m.dartagnan.parsers.witness.ParserWitness;
Expand Down Expand Up @@ -414,8 +416,9 @@ public static ResultSummary generateResultSummary(VerificationTask task, ProverE
summary.append(result).append("\n");
} else {
// Litmus-specific output format that matches with Herd7 (as good as it can)
if (p.getFilterSpecification() != null) {
summary.append("Filter ").append(p.getFilterSpecification()).append("\n");
Expression filterSpec = p.getFilterSpecification();
if (!(filterSpec instanceof BoolLiteral bLit) || !bLit.getValue()) {
summary.append("Filter ").append(filterSpec).append("\n");
}

// NOTE: We cannot produce an output that matches herd7 when checking for both program spec and cat properties.
Expand Down