Skip to content

Fix witnesses excluding the rf edges they enforce. #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Fix witnesses excluding the rf edges they enforce. #771

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d62546
Fix witnesses excluding the rf edges they enforce.
xeren Nov 5, 2024
4bdcb62
fixup! Fix witnesses excluding the rf edges they enforce.
xeren Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dartagnan/src/main/java/com/dat3m/dartagnan/wmm/analysis/NativeRelationAnalysis.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -875,7 +875,7 @@ public MutableKnowledge visitReadFrom(ReadFrom rf) {
EventGraph g = witness.getReadFromKnowledge(program, alias);
must.addAll(g);
for (Event r : g.getRange()) {
may.removeIf((e1, e2) -> e2 == r);
may.removeIf((e1, e2) -> e2 == r && !g.contains(e1, e2));
}
}

Expand Down
2 changes: 0 additions & 2 deletions svcomp.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,3 @@ encoding.integers=true
svcomp.step=5
svcomp.umax=27
witness=graphml
// We can get rid of the option below once #767 is fixed
wmm.analysis.extendedRelationAnalysis=false
Loading