Skip to content

Check if events may alias when deriving RA knowledge from witnesses (… #766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 4, 2024
Merged

Check if events may alias when deriving RA knowledge from witnesses (… #766

merged 3 commits into from
Nov 4, 2024

Conversation

hernanponcedeleon
Copy link
Owner

…as a safe guard)

@ThomasHaas
Copy link
Collaborator

This is really a band-aid fix. The code is still wrong and you should put at least a FIXME.

ThomasHaas
ThomasHaas approved these changes Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@ThomasHaas ThomasHaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hernanponcedeleon hernanponcedeleon merged commit fa5a25c into development Nov 4, 2024
1 check passed
@hernanponcedeleon hernanponcedeleon deleted the witness-validation branch November 4, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasHaas ThomasHaas ThomasHaas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hernanponcedeleon @ThomasHaas @hernan-poncedeleon