Skip to content

Require the existence of violation node when validate violation witness #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2024

Conversation

hernanponcedeleon
Copy link
Owner

This PRs solves #349.

This is a witness we should actually not validate

<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<graphml xmlns="http://graphml.graphdrawing.org/xmlns" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
<key attr.name="architecture" attr.type="string" for="graph" id="architecture"/>
<key attr.name="creationtime" attr.type="string" for="graph" id="creationtime"/>
<key attr.name="producer" attr.type="string" for="graph" id="producer"/>
<key attr.name="programfile" attr.type="string" for="graph" id="programfile"/>
<key attr.name="programhash" attr.type="string" for="graph" id="programhash"/>
<key attr.name="sourcecodelang" attr.type="string" for="graph" id="sourcecodelang"/>
<key attr.name="specification" attr.type="string" for="graph" id="specification"/>
<key attr.name="witness-type" attr.type="string" for="graph" id="witness-type"/>
<key attr.name="unroll-bound" attr.type="string" for="graph" id="unroll-bound"/>
<key attr.name="entry" attr.type="boolean" for="node" id="entry"/>
<key attr.name="violation" attr.type="boolean" for="node" id="violation"/>
<key attr.name="createThread" attr.type="string" for="edge" id="createThread"/>
<key attr.name="threadId" attr.type="string" for="edge" id="threadId"/>
<key attr.name="enterFunction" attr.type="string" for="edge" id="enterFunction"/>
<key attr.name="startline" attr.type="string" for="edge" id="startline"/>
<graph edgedefault="directed">
  <data key="architecture">32bit</data>
  <data key="creationtime">2024-10-11T20:22:16Z</data>
  <data key="producer">Dartagnan</data>
  <data key="programfile">../sv-benchmarks/c/pthread/lazy01.i</data>
  <data key="programhash">b5d87933b05ad3566f9bc28daac5c0aeceb8a45433a1cac3d51a8d34f7f284f0</data>
  <data key="sourcecodelang">C</data>
  <data key="specification">CHECK( init(main()), LTL(G ! call(reach_error())))</data>
  <data key="unroll-bound">1</data>
  <data key="witness-type">violation_witness</data>
  <node id="N0">
    <data key="entry">true</data>
  </node>
  <node id="N1">
  </node>
  <node id="N10">
  </node>
  <node id="N11">
  </node>
  <node id="N12">
  </node>
  <node id="N13">
  </node>
  <node id="N14">
  </node>
  <node id="N15">
  </node>
  <node id="N16">
  </node>
  <node id="N17">
  </node>
  <node id="N2">
  </node>
  <node id="N3">
  </node>
  <node id="N4">
  </node>
  <node id="N5">
  </node>
  <node id="N6">
  </node>
  <node id="N7">
  </node>
  <node id="N8">
  </node>
  <node id="N9">
  </node>
  <edge source="N0" target="N1">
    <data key="createThread">0</data>
  </edge>
  <edge source="N1" target="N2">
    <data key="enterFunction">main</data>
    <data key="threadId">0</data>
  </edge>
  <edge source="N2" target="N3">
    <data key="startline">730</data>
    <data key="threadId">0</data>
  </edge>
  <edge source="N3" target="N4">
    <data key="createThread">1</data>
    <data key="startline">732</data>
    <data key="threadId">0</data>
  </edge>
  <edge source="N4" target="N5">
    <data key="createThread">2</data>
    <data key="startline">733</data>
    <data key="threadId">0</data>
  </edge>
  <edge source="N5" target="N6">
    <data key="startline">713</data>
    <data key="threadId">2</data>
  </edge>
  <edge source="N6" target="N7">
    <data key="startline">714</data>
    <data key="threadId">2</data>
  </edge>
  <edge source="N7" target="N8">
    <data key="startline">715</data>
    <data key="threadId">2</data>
  </edge>
  <edge source="N8" target="N9">
    <data key="startline">706</data>
    <data key="threadId">1</data>
  </edge>
  <edge source="N9" target="N10">
    <data key="startline">707</data>
    <data key="threadId">1</data>
  </edge>
  <edge source="N10" target="N11">
    <data key="createThread">3</data>
    <data key="startline">734</data>
    <data key="threadId">0</data>
  </edge>
  <edge source="N11" target="N12">
    <data key="startline">708</data>
    <data key="threadId">1</data>
  </edge>
  <edge source="N12" target="N13">
    <data key="startline">720</data>
    <data key="threadId">3</data>
  </edge>
  <edge source="N13" target="N14">
    <data key="startline">735</data>
    <data key="threadId">0</data>
  </edge>
  <edge source="N14" target="N15">
    <data key="startline">720</data>
    <data key="threadId">3</data>
  </edge>
  <edge source="N15" target="N16">
    <data key="startline">736</data>
    <data key="threadId">0</data>
  </edge>
  <edge source="N16" target="N17">
    <data key="startline">721</data>
    <data key="threadId">3</data>
  </edge>
</graph></graphml>

Copy link
Collaborator

@ThomasHaas ThomasHaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hernanponcedeleon hernanponcedeleon merged commit 878d282 into development Oct 12, 2024
1 check passed
@hernanponcedeleon hernanponcedeleon deleted the violation-node branch October 12, 2024 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants