Skip to content

Fixing registry client for packaging charts with OCI dependencies #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

bartlettc22
Copy link
Contributor

Fixes: #225

@kingdonb
Copy link

kingdonb commented Nov 3, 2022

Thank you for contributing this @bartlettc22 !

Can you rebase your commit with --sign-off so the DCO check goes away? I am not a valid reviewer for this repo, but I am interested and I know this will be the first thing that needs update. I will test this change 👍

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

can you sign the dco?

@bartlettc22
Copy link
Contributor Author

Ah, my bad. Should be all set now.

@kingdonb
Copy link

kingdonb commented Nov 7, 2022

@cpanato can you kick off the remaining workflows now that DCO check is OK?

@cpanato
Copy link
Member

cpanato commented Nov 23, 2022

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subcharts referenced via OCI registry fail to package
3 participants