operational transformation #659
Conversation
| break; | ||
| } | ||
| (Some(Insert(_)), _) => { | ||
| a_.add(head_a.take().unwrap()); |
There was a problem hiding this comment.
I'd just call a_.insert(s) here and get rid of add
There was a problem hiding this comment.
I can't do this because of borrow checker things, it would move out
| (None, None) => { | ||
| break; | ||
| } | ||
| (Some(Insert(_)), _) => { |
There was a problem hiding this comment.
Given that there's just one or two places that handle Insert I wonder if OperationView is needed
There was a problem hiding this comment.
it is needed because of borrow checker things. Because we only borrow the second ChangeSet, it will yield references which we can't use. So we convert it to an OperationView because we don't actually need the Tendril, we only need the length. That way the type becomes copyable, and we get pattern matching coverage checking
the-mikedavis
added
the
S-waiting-on-review
|
Closing as inactive. Feel free to open a new PR if you wish to continue. |
kirawi
added
S-inactive
adds functions
mapandmap_bothTODO: