Skip to content

Fix comment #3334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 6, 2022
Merged

Fix comment #3334

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8c88056
Fix comment
AceofSpades5757 Aug 4, 2022
ab310dd
Merge branch 'master' of github.com:helix-editor/helix into fix-comment
AceofSpades5757 Aug 5, 2022
ac3a8df
Fix comment
AceofSpades5757 Aug 5, 2022
15f9861
Merge branch 'master' of github.com:helix-editor/helix into fix-comment
AceofSpades5757 Aug 6, 2022
0c164ee
Run formatter
AceofSpades5757 Aug 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion helix-view/src/document.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -576,7 +576,7 @@ impl Document {
}

/// Detect the indentation used in the file, or otherwise defaults to the language indentation
/// configured in `languages.toml`, with a fallback to 4 space indentation if it isn't
/// configured in `languages.toml`, with a fallback to the default indentation if it isn't
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should either say what the default value is ("tabs") or link to DEFAULT_INDENT

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. Had issues linking the variable, so went with "tabs". It was complaining that it was private, but then still complained when I ran with the respective flag.

/// specified. Line ending is likewise auto-detected, and will fallback to the default OS
/// line ending.
pub fn detect_indent_and_line_ending(&mut self) {
Expand Down