Skip to content

helix_view::theme [WARN] Theme #3119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 22, 2022
Merged

helix_view::theme [WARN] Theme #3119

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7ce6650
helix_view::theme [WARN] Theme
Jul 14, 2022
e1d406b
Merge remote-tracking branch 'helix/master' into remove-theme-warnings
aikomastboom Jul 21, 2022
8eb861e
updated: warning, error, info, hint colours
aikomastboom Jul 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion runtime/themes/catppuccin.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ label = "peach"

"diff.plus" = "#35bf86"
"diff.minus" = "#f22c86"
"diff.delta" = "#6f44f0"
"diff.delta" = "delta"

"ui.background" = { bg = "black_2" }
"ui.linenr" = { fg = "gray_0" }
Expand Down Expand Up @@ -91,3 +91,8 @@ gray_2 = "#C3BAC6"
white = "#D9E0EE"
lavender = "#C9CBFF"
rosewater = "#F5E0DC"

silver = "#c0c0c0"
apricot = "#f47868"
lightning = "#ffcd1c"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These three keys are from the default theme file, probably a remnant from being copied. The catppuccin style guide recommends using maroon for errors and peach for warnings (which is where these palette keys are used in this file). Something mild like lavender would be a good fit for the hint key too.

delta = "#6f44f0"
2 changes: 1 addition & 1 deletion runtime/themes/dracula.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"ui.background" = { fg = "foreground", bg = "background" }
"ui.cursor" = { fg = "background", bg = "orange", modifiers = ["dim"] }
"ui.cursor.match" = { fg = "green", modifiers = ["underlined"] }
"ui.cursor.primary" = { fg = "background", bg = "cyan", modifier = ["dim"] }
"ui.cursor.primary" = { fg = "background", bg = "cyan", modifiers = ["dim"] }
"ui.cursorline.primary" = { bg = "background_dark" }
"ui.help" = { fg = "foreground", bg = "background_dark" }
"ui.linenr" = { fg = "comment" }
Expand Down
2 changes: 1 addition & 1 deletion runtime/themes/dracula_at_night.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"ui.background" = { fg = "foreground", bg = "background" }
"ui.cursor" = { fg = "background", bg = "orange", modifiers = ["dim"] }
"ui.cursor.match" = { fg = "green", modifiers = ["underlined"] }
"ui.cursor.primary" = { fg = "background", bg = "cyan", modifier = ["dim"] }
"ui.cursor.primary" = { fg = "background", bg = "cyan", modifiers = ["dim"] }
"ui.help" = { fg = "foreground", bg = "background_dark" }
"ui.linenr" = { fg = "comment" }
"ui.linenr.selected" = { fg = "foreground" }
Expand Down
2 changes: 1 addition & 1 deletion runtime/themes/noctis.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@
# Version control changes.

'diff.plus' = "light-green" # { } # Additions.
'diff.minus' = "yelllow" # { } # Deletions.
'diff.minus' = "yellow" # { } # Deletions.
'diff.delta' = "red" # { } # Modifications.
'diff.delta.moved' = { } # Renamed or moved files / changes.

Expand Down
4 changes: 2 additions & 2 deletions runtime/themes/rose_pine.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@
"markup.heading.2" = { fg = "gold", modifiers = ["bold"] }
"markup.heading.3" = { fg = "rose", modifiers = ["bold"] }
"markup.heading.4" = { fg = "pine", modifiers = ["bold"] }
"markup.heading.5" = { fg = "form", modifiers = ["bold"] }
"markup.heading.6" = { fg = "fg", modifiers = ["bold"] }
"markup.heading.5" = { fg = "foam", modifiers = ["bold"] }
"markup.heading.6" = { fg = "iris", modifiers = ["bold"] }
"markup.list" = { fg = "love" }
"markup.bold" = { fg = "gold", modifiers = ["bold"] }
"markup.italic" = { fg = "iris", modifiers = ["italic"] }
Expand Down
4 changes: 2 additions & 2 deletions runtime/themes/rose_pine_dawn.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,8 @@
"markup.heading.2" = { fg = "gold", modifiers = ["bold"] }
"markup.heading.3" = { fg = "rose", modifiers = ["bold"] }
"markup.heading.4" = { fg = "pine", modifiers = ["bold"] }
"markup.heading.5" = { fg = "form", modifiers = ["bold"] }
"markup.heading.6" = { fg = "fg", modifiers = ["bold"] }
"markup.heading.5" = { fg = "foam", modifiers = ["bold"] }
"markup.heading.6" = { fg = "iris", modifiers = ["bold"] }
"markup.list" = { fg = "love" }
"markup.bold" = { fg = "gold", modifiers = ["bold"] }
"markup.italic" = { fg = "iris", modifiers = ["italic"] }
Expand Down
7 changes: 4 additions & 3 deletions runtime/themes/serika-dark.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@

"ui.background" = { bg = "bg0" }
"ui.cursor" = { fg = "bg0", bg = "fg" }
"ui.cursor.match" = { fg = "grey3", bg = "grey2" }
"ui.cursor.match" = { fg = "grey0", bg = "grey2" }
"ui.cursor.insert" = { fg = "bg0", bg = "bg_yellow" }
"ui.cursor.select" = { fg = "bg0", bg = "bg_yellow" }
"ui.linenr" = "yellow"
Expand All @@ -56,7 +56,7 @@
"info" = "aqua"
"warning" = "yellow"
"error" = "nasty-red"
"diagnostic" = { fg = "dark-red", Modifiers = ["underlined"] }
"diagnostic" = { fg = "dark-red", modifiers = ["underlined"] }

"diff.plus" = { fg = "green" }
"diff.delta" = { fg = "orange" }
Expand All @@ -69,7 +69,7 @@
"markup.link.url" = "cyan"
"markup.link.text" = "pink"
"markup.quote" = { fg = "yellow", modifiers = ["italic"] }
"markup.raw" = { fg = "foreground" }
"markup.raw" = { fg = "fg" }

[palette]

Expand Down Expand Up @@ -98,3 +98,4 @@ purple = "#d0c4d4"
grey0 = "#aaaeb3"
grey1 = "#e1e1e3"
grey2 = "#646669"
pink = "#e06c75"
7 changes: 4 additions & 3 deletions runtime/themes/serika-light.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
"info" = "aqua"
"warning" = "yellow"
"error" = "nasty-red"
"diagnostic" = { fg = "dark-red", Modifiers = ["underlined"] }
"diagnostic" = { fg = "dark-red", modifiers = ["underlined"] }

"diff.plus" = { fg = "green" }
"diff.delta" = { fg = "orange" }
Expand All @@ -69,7 +69,7 @@
"markup.link.url" = "cyan"
"markup.link.text" = "pink"
"markup.quote" = { fg = "yellow", modifiers = ["italic"] }
"markup.raw" = { fg = "foreground" }
"markup.raw" = { fg = "fg" }


[palette]
Expand All @@ -91,11 +91,12 @@ red = "#621d28"
nasty-red = "#da3333"
dark-red = "#791717"
orange = "#57320f"
yellow = "#e2b714"
yellow = "#9a7d0e"
green = "#3f4b34"
aqua = "#455054"
blue = "#3f5673"
purple = "#534059"
grey0 = "#aaaeb3"
grey1 = "#e1e1e3"
grey2 = "#646669"
pink = "#e06c75"
2 changes: 1 addition & 1 deletion runtime/themes/snazzy.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"ui.background" = { fg = "foreground", bg = "background" }
"ui.cursor" = { fg = "background", bg = "blue", modifiers = ["dim"] }
"ui.cursor.match" = { fg = "green", modifiers = ["underlined"] }
"ui.cursor.primary" = { fg = "background", bg = "cyan", modifier = ["dim"] }
"ui.cursor.primary" = { fg = "background", bg = "cyan", modifiers = ["dim"] }
"ui.help" = { fg = "foreground", bg = "background_dark" }
"ui.linenr" = { fg = "comment" }
"ui.linenr.selected" = { fg = "foreground" }
Expand Down