Add support for multiple language servers per language#2507

Merged

archseer merged 41 commits intohelix-editor:masterfrom

Philipp-M:multiple-language-servers

May 19, 2023

Commits on May 18, 2023

Adds support for multiple language servers per language.
Philipp-M
committed
Fix 'WorkspaceConfiguration' request with empty configuration section strings
Philipp-M
committed
Fix some lints/docgen hints
Philipp-M
committed
Fix hardcoded offset_encoding
Philipp-M
committed
Fix issue with ltex-ls, filtering params is not what we want here
Philipp-M
committed
Remove unnecessary completion support check (likely an artifact)
Philipp-M
committed
str instead of String
Philipp-M
committed
Fix sorting issues of the editor wide diagnostics and apply diagnostics related review suggestions

Philipp-M
and
pascalkuthe
committed
Simplify Display implementation of LanguageServerFeature

Philipp-M
and
pickfire
committed
Fix error messages when no language server is available

Philipp-M
and
dead10ck
committed
Use DoubleEndedIterator instead of collect to Vec for reversing

Philipp-M
and
pascalkuthe
committed
Refactored doc.language_servers and doc.language_servers_with_feature to return an iterator and refactor LanguageServerFeature handling to a HashMap (language server name maps to features)

Philipp-M
and
pascalkuthe
committed
Simplify Display implementation for LanguageServerFeature
Philipp-M
committed
Add method doc.supports_language_server for better readability
Philipp-M
committed
Refactor doc.shown_diagnostics to avoid an extra HashSet

Philipp-M
and
pascalkuthe
committed
Format/fix language docs a bit
Philipp-M
committed
Remove boilerplate in the goto methods by generically composing functions
Philipp-M
committed
Fix docgen and lsp-stop documentation
Philipp-M
committed
Simplify 'lsp_stop' command
Philipp-M
committed
Remove symbol picker is_empty check
Philipp-M
committed
Refactor doc language servers to a HashMap, and the config to use a Vec to retain order
Philipp-M
committed
Remove offset_encoding in CompletionItem
Philipp-M
committed
Use let else instead of variable and fix some error messages

Philipp-M
and
pascalkuthe
committed
Optimize gutter diagnostics and simplify shown_diagnostics
Philipp-M
committed
Filter out already seen language servers in requests that can be sent to multiple language servers (code-action, completion, symbol pickers)
Philipp-M
committed
Fix docgen again
Philipp-M
committed
Filter language servers also by capabilities in `doc.language_servers_with_feature`
Philipp-M
committed
Maintain language servers TOML array order in `doc.language_servers`
Philipp-M
committed
Remove offset_encoding in CodeActionOrCommandItem, as it can be retrieved on demand
Philipp-M
committed
Fix crash with filtered diagnostics in gutter (e.g. when diagnostics aren't visible)
Philipp-M
committed
Fix lsp_restart across multiple different document scopes (language servers weren't restarted, if not of the same scope id), and fix some smaller rebase issues
Philipp-M
committed
Reduce boilerplate by 'use lsp::*' in Client::supports_feature, and remove TODO comment
Philipp-M
committed
Reorder id generation for Clients to stay close to the old behavior
Philipp-M
committed
Remove TODO comment in helix_lsp::Registry::restart and add doc-comment on top of function instead
Philipp-M
committed
Add function `Editor::language_server_by_id` and refactor/simplify related code, also don't 'crash' in completion menu if language_server somehow disappeared
Philipp-M
committed
Some minor clarity/cosmetic improvements

Philipp-M
and
pascalkuthe
committed
Simplify gutter diagnostics rendering by using partition_point instead of binary search

Philipp-M
and
pascalkuthe
committed
Apply all review suggestions (doc_id -> id, error message, unnecessary if)

Philipp-M
and
pascalkuthe
committed
Sort language servers table in languages.toml and rename language server 'R' to 'r'
Philipp-M
committed
Clarify language-servers documentation for mergeable LSP features (`diagnostics`, `code-action`, `completion`, `document-symbols` and `workspace-symbols`)
Philipp-M
committed
Rebase cleanup/fixes and use lsp::CompletionItem in item_to_transaction directly
Philipp-M
committed