-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat: Make the diagnostic picker display the resposible LSP #13758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Make the diagnostic picker display the resposible LSP #13758
Conversation
Signed-off-by: RmStorm <[email protected]>
af8fffa
to
7c7cca1
Compare
This issue points out that diagnostics can be hard to read, particularly in the workspace diagnostics picker. I think my PR makes that worse.. Maybe I should check if there are multiple lsp's active? And then only display the source when that is the case? |
This is an issue I regularly deal with because I often have a sidepane open on a somewhat small screen. It kinda depends on what the maintainers say, but my 2c here is that:
|
Yeah, this picker is quite crowded. Using Hiding this column when there is only one language server active would make some sense at the moment but as we expand diagnostics to include things like spell checking we would need to remove that anyways. |
Solves #12474 and #11452
This should probably be configurable so my current approach is very naive. I just wanted to quickly whip something up for myself.
When programming in Python multiple/many LSP's is the norm and it can be hard to make sense of things. Hence this PR that displays the LSP responsible for a certain diagnostic in the picker.