Skip to content

tree-house: Inject rust language into documentation comments when the language is not specified #13116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 15, 2025

Conversation

nik-rev
Copy link
Contributor

@nik-rev nik-rev commented Mar 14, 2025

This PR is described in #12972 (comment)

@nik-rev nik-rev changed the base branch from master to tree-house March 14, 2025 21:22
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the long run we should consider a more generic way to do this - maybe an extra property that could be added to the markdown injections like (#set! injection.language injection.parent-layer) which would only match if markdown was in an injection and would cause markdown to use Rust in this case. The hope would be to avoid adding a bunch of markdown-<parent> languages for other languages that inject markdown for documentation.

In the short term though it's very cheap to add another language that inherits another

@the-mikedavis the-mikedavis merged commit d04f940 into helix-editor:tree-house Mar 15, 2025
6 checks passed
@nik-rev nik-rev deleted the rustdoc-injection branch March 15, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants