Default theme: Use different highlight color for secondary selections #11080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe @archseer would prefer that the primary selection's cursor be a different color rather than the entire selection. See #3842 (comment), #5315 (comment) |
|
Thanks for the heads up, I must've missed those comments. I'll see if I can come up with something like that. |
rmburg
force-pushed
the
highlight-color-default
branch
from
2b3765a to
68da857
Compare
rmburg
force-pushed
the
highlight-color-default
branch
from
68da857 to
4dc83dd
Compare
|
I updated the PR according to your suggestions. Apologies for the delay! This is how it looks now: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #3842.
The new color was chosen as half-way between the primary selection's background color and the window background color. This is kind of arbitrary, and I will happily change the color if so desired.
Before:
After:
