Cursor color should take priority over visual indent guides

[mandx]

Summary

I was expecting this PR to fix my issue with indent guides coloring, but looks like it doesn't?

I have a custom theme, with just this override (this is the entire contents of the theme file):

inherits = "gruvbox_dark_hard"
"ui.virtual.indent-guide" = "#000000"

Without the ui.virtual.indent-guide override, it looks like this:

And with the latest local build (I checked I have this PR already) and the override enabled, it looks like this:

The black indent guides look as expected, but I was expecting the cursor (and only the cursor) to look like in the first screenshot.

These are my cursor shape and indent guide settings:

[editor.cursor-shape]
insert = "bar"
normal = "block"
select = "underline"

[editor.indent-guides]
character = "▏"
skip-level = 1
render = true

Which makes the issue more evident when I switch to Insert mode:

The cursor is at the same position as in the second screenshot, but it's effectively invisible.

Reproduction Steps

I tried this:

1. Create and select a custom theme with just this in it:

inherits = "gruvbox_dark_hard"
"ui.virtual.indent-guide" = "#000000"

2. Set this in Helix settings:

[editor.cursor-shape]
insert = "bar"
normal = "block"
select = "underline"

[editor.indent-guides]
character = "▏"
skip-level = 1
render = true

I expected the cursor to look like this when positioned on an indent guide:

Instead, it looks like this:

Helix log

~/.cache/helix/helix.log

``` [helix.log](https://github.com/helix-editor/helix/files/13464893/helix.log) ```

Platform

Linux

Terminal Emulator

alacritty 0.12.3

Installation Method

source

Helix Version

23.10-75-g8c68074f

[nalply]

Perhaps related: if a cursor is on a ruler, the cursor and the character disappears.

[mandx]

@nalply I believe the case specific to rulers is being tracked here #7371