Skip to content

diff.plus, diff.minus and diff.delta theme keys need updating for many themes for git gutters #4972

@David-Else

Description

@David-Else

Since git gutters landed #3890 many themes need the diff colors updating, I have taken screen shots of the ones I consider in obvious need of attention, but appreciate some changes may be subjective.

*EDIT There is also "diff.delta.moved" to consider, I missed that, I am not sure if it is needed?
*EDIT Theme authors, a new release of Helix is planned this weekend, so please make any changes you want ASAP :)

  • emacs
  • flatwhite
  • kanagawa
  • serika_light
  • acme
  • nord_light
  • hex_steel
  • hex_toxic
  • zenburn
  • doom_acario_dark

Correct Example

Here is an example of dark_plus (VS Code theme) which has been updated specifically for #3890:

dark_plus_correct

Need Attention

There follows screen shots of those that seem in need of updates, there maybe more, this is just my opinion. I have tried to add a ping to the authors:

@Yevgnen
Screenshot from 2022-12-02 14-57-48

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-themeArea: Theme and appearence relatedC-enhancementCategory: Improvements

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions