Signature help gets stuck

[theli-ua]

Summary

Occasionally signature help gets stuck without (at least I couldn't find it) ability to to hide it.
I am yet to come up with minimal reproduction example but once I find it I'll update this.

(this all not to say that signature help in general makes experience incredibly frustrating inside things as iterator::map or , say, tokio::spawn)

Reproduction Steps

pending

Helix log

~/.cache/helix/helix.log

I am unable to share full log and could not find anything relevant there

Platform

Linux

Terminal Emulator

kitty

Helix Version

helix 22.05 (791bf7e)

[kirawi]

Does esc or ctrl-c not work to close it?

[joegm]

Does esc or ctrl-c not work to close it?

For me C-c works to close it but not esc.

I also managed to reproduce it by creating a macro that just enters and then exits insert mode, then running it with the cursor on a function parameter.

[theli-ua]

C-c works indeed

[the-mikedavis]

When I see this get stuck, I think it's because the signature help reply arrives when we're in normal mode. I see this getting stuck much more often with a slow language server (erlang_ls) rather than a fast language server (rust-analyzer). When it arrives in insert mode and we switch to normal mode, the popup is closed by this block:

helix/helix-term/src/ui/editor.rs

Lines 857 to 862 in 8a7a6e4

	cxt.jobs.callback(async {
	let call: job::Callback = Box::new(|_editor, compositor| {
	compositor.remove(SignatureHelp::ID);
	});
	Ok(call)
	});

I think it would be a good improvement to discard the signature help reply when the editor is in normal mode.